Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly define compilation constant for target framework without version #2073

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Implicitly define compilation constant for target framework without version #2073

merged 1 commit into from
Mar 21, 2018

Conversation

david-driscoll
Copy link
Contributor

Added ImplicitFrameworkDefineHierarchy property with out the versioned value for the given TargetFrameworkIdentifier

More information and origin @ #2072

🚲🏠 Please bike shed this, I just tried pick a name that worked, without changing the meaning of the existing properties. Hierarchy, Parent, Root are all possibly valid values, along with many more.

@dsplaisted
Copy link
Member

Thanks for the PR!

I'd suggest VersionlessImplicitFrameworkDefine, and re-ordering where it's defined to before NETFRAMEWORK is special-cased to NET so you don't need a separate property like you currently have with _FrameworkIdentifierForImplicitDefineHierarchy.

Also there are a lot of whitespace changes, it would be nice if you could exclude those changes.

@dsplaisted dsplaisted changed the base branch from master to release/2.1.3xx March 21, 2018 18:53
@dsplaisted dsplaisted changed the base branch from release/2.1.3xx to master March 21, 2018 18:53
@dsplaisted
Copy link
Member

Also, can you rebase this PR to release/2.1.3xx branch? I tried changing the target branch by editing the PR, but that ended up bringing in some extra commits.

@david-driscoll
Added VersionlessImplicitFrameworkDefine property with the unversione…
043e7ea 
…d value for the given TargetFrameworkIdentifier
@david-driscoll david-driscoll changed the base branch from master to release/2.1.3xx March 21, 2018 19:49
@david-driscoll
Copy link
Contributor Author

@dsplaisted whitespace removed, property renamed, and I did a cherry-pick over to release/2.1.3xx and changed the target branch in github. Hopefully this looks right 💹.

@dsplaisted
Copy link
Member

@dotnet-bot test Ubuntu14.04 Debug
test Ubuntu16.04 Release

@dsplaisted dsplaisted merged commit 75d4e57 into dotnet:release/2.1.3xx Mar 21, 2018
@dsplaisted
Copy link
Member

@MattGertz FYI for tell mode

This was referenced Jan 22, 2019
Merged
Merged
@maca88 maca88 mentioned this pull request Mar 27, 2022
Merged
JL03-Yue pushed a commit that referenced this pull request Mar 19, 2024
@dotnet-maestro @jjonescz
[main] Update dependencies from dotnet/command-line-api (#2073)
1716d9e 
* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240118.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.506801

* Update dependencies from https://github.com/dotnet/command-line-api build 20240201.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.510101

* Update dependencies from https://github.com/dotnet/command-line-api build 20240202.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.510201

* Update dependencies from https://github.com/dotnet/command-line-api build 20240202.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.510201

* Update dependencies from https://github.com/dotnet/command-line-api build 20240202.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.510201

* Update dependencies from https://github.com/dotnet/command-line-api build 20240202.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.505902 -> To Version 0.1.510201

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jan Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@peterhuene peterhuene peterhuene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-driscoll @dsplaisted @peterhuene