Allow compileTimeTarget.Libraries.Count == _runtimeTarget.Libraries.Count #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As demonstrated by the failed test, this isn't a valid change. We are catching the case where you've specified a RID and haven't gotten any RID specific assets. The common case for this is a typo in the RID. Without this check, you just get a self contained app without any runtime bits. See also @dsplaisted's comment on the issue. Let's first understand why you don't expect any runtime specific assets in your case with RID set and then we can discuss the right change. |
|
This change is also equivalent to removing the error unconditionally because the runtime library set is never a strict subset of the compile time library set. |
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jun 7, 2022
* fixes dotnet/templating dotnet#2503 dotnet/templating dotnet#2014: - corrects error message when value provided for parameter is incorrect: it should show the input paramater as enterd by user and not canonical name - when when value provided for parameter is incorrect: do not show generic help and help for template, just error message
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jul 11, 2022
* fixes dotnet/templating dotnet#2503 dotnet/templating dotnet#2014: - corrects error message when value provided for parameter is incorrect: it should show the input paramater as enterd by user and not canonical name - when when value provided for parameter is incorrect: do not show generic help and help for template, just error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this pull request as an attempt to fix issue #2503.
I am not sure what is the underlying rationale to requires
compileTimeTarget.Libraries.Count **strictly ** less than _runtimeTarget.Libraries.Count
So I relaxed the condition to allow equals as well.