Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set server GC for F# FSC/FSI #29505

Closed
wants to merge 1 commit into from
Closed

Set server GC for F# FSC/FSI #29505

wants to merge 1 commit into from

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Dec 12, 2022

As we figured out here, SDK is not getting runtimeconfig.json files from F# itself, but from the https://github.com/dotnet/sdk/blob/main/src/Layout/tool_fsharp/tool_fsc.csproj:

<!-- Deploy deps and runtime config for fsc.exe and fsi.exe. Both apps have exactly the same dependencies so this is Ok -->
<Copy SourceFiles="$(FSharpDirectory)/tool_fsc.runtimeconfig.json;
$(FSharpDirectory)/tool_fsc.deps.json;"
DestinationFiles="$(FSharpDirectory)/fsc.runtimeconfig.json;
$(FSharpDirectory)/fsc.deps.json;"/>
<Copy SourceFiles="$(FSharpDirectory)/tool_fsc.runtimeconfig.json;
$(FSharpDirectory)/tool_fsc.deps.json;"
DestinationFiles="$(FSharpDirectory)/fsi.runtimeconfig.json;
$(FSharpDirectory)/fsi.deps.json;"/>

Hopefully, it's the proper place to make the change, if not, please advise what would be thecorrect one.

Update: will also need to verify that these changes do affect runtimeconfig, when build is complete.

@vzarytovskii vzarytovskii changed the base branch from main to release/7.0.2xx December 12, 2022 16:54
@vzarytovskii vzarytovskii changed the base branch from release/7.0.2xx to main December 12, 2022 16:54
@vzarytovskii
Copy link
Member Author

Apologies for ping, everyone, github seems to do that automatically if you re-target the branch. I will reopen it for the appropriate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant