Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Agent.TempDirectory when building from archive in source-build #45532

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Dec 18, 2024

This avoids 1ES scanners finding secrets in Build.ArtifactStagingDirectory that we already suppressed via CredScanSuppressions.json

Fixes dotnet/source-build#4773

@akoeplinger akoeplinger requested review from a team as code owners December 18, 2024 14:19
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 18, 2024
@akoeplinger akoeplinger enabled auto-merge (squash) December 18, 2024 15:45
@akoeplinger akoeplinger merged commit 124be38 into main Dec 18, 2024
36 of 38 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-2 branch December 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[main] VMR Credential Scanner failed
3 participants