Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -e option to dotnet run #45795

Open
wants to merge 7 commits into
base: release/9.0.2xx
Choose a base branch
from
Open

Add -e option to dotnet run #45795

wants to merge 7 commits into from
+802 −474

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 8, 2025 •
edited
Loading

Implements #45740

@tmat tmat requested a review from a team as a code owner January 8, 2025 20:51
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CLI untriaged Request triage from a team member labels Jan 8, 2025
baronfel
baronfel approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I left a note about how we can model the -e option more directly to make it easier for consumers to use.

src/Cli/dotnet/commands/dotnet-run/Program.cs Outdated Show resolved Hide resolved
This was referenced Jan 9, 2025
Open
Open
Open
Open
@baronfel baronfel requested a review from a team January 9, 2025 03:16
@build-analysis build-analysis bot mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

@joeloff joeloff joeloff approved these changes

Assignees
No one assigned
Labels
Area-CLI untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @baronfel @joeloff