Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/aspnetcore #45917

Merged
merged 13 commits into from
Jan 14, 2025
Merged

[main] Update dependencies from dotnet/aspnetcore #45917

merged 13 commits into from
Jan 14, 2025
+53 −191

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 13, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: 4491d9a4-839d-4af5-f3e4-08d8e97c775d
  • Build: 20250114.1
  • Date Produced: January 14, 2025 10:38:11 AM UTC
  • Commit: 6ce45ab5b1ae650552e0cb6d41ed25261fa799c4
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
87339ef 
…0250112.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.25061.1 -> To Version 10.0.0-alpha.2.25062.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jan 13, 2025
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/aspnetcore:

@dotnet/aspnet-build

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/aspnetcore) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@build-analysis build-analysis bot mentioned this pull request Jan 13, 2025
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
bb1453d 
…0250112.2

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.25061.1 -> To Version 10.0.0-alpha.2.25062.2
@v-wuzhai
Copy link
Member

@dotnet/product-construction Could you take a look at the failures here?

@ViktorHofer ViktorHofer requested review from a team as code owners January 13, 2025 10:51
@ViktorHofer
Copy link
Member

@MichalStrehovsky is this a known issue? I think I already saw this at least once in another PR here.

    EXEC : error : One or more errors occurred. (Code generation failed for method '[System.Runtime.InteropServices]System.Runtime.InteropServices.Marshalling.ComExposedClassAttribute`1<System.__Canon>..ctor()') [/__w/1/vmr/src/runtime/src/native/managed/cdacreader/src/cdacreader.csproj]
      System.AggregateException: One or more errors occurred. (Code generation failed for method '[System.Runtime.InteropServices]System.Runtime.InteropServices.Marshalling.ComExposedClassAttribute`1<System.__Canon>..ctor()')
       ---> ILCompiler.CodeGenerationFailedException: Code generation failed for method '[System.Runtime.InteropServices]System.Runtime.InteropServices.Marshalling.ComExposedClassAttribute`1<System.__Canon>..ctor()'
       ---> ILCompiler.NativeAotFatalErrorException: ILC: error IL1013: Error processing 'name'.
       ---> System.NullReferenceException: Object reference not set to an instance of an object.
         at System.Xml.XPath.XNodeNavigator.MoveToFirstChild() + 0x22
         at MS.Internal.Xml.XPath.XPathChildIterator.MoveNext() + 0x1c
         at ILCompiler.ProcessLinkerXmlBase.ProcessAssemblies(XPathNavigator) + 0x3d3
         at ILCompiler.ProcessLinkerXmlBase.ProcessXml(Boolean) + 0x105
         --- End of inner exception stack trace ---
         at ILCompiler.ProcessLinkerXmlBase.ProcessXml(Boolean) + 0x25b
         at ILCompiler.SubstitutionProvider.AssemblyFeatureInfo..ctor(EcmaModule, Logger, IReadOnlyDictionary`2, BodyAndFieldSubstitutions) + 0x672
         at ILCompiler.SubstitutionProvider.FeatureSwitchHashtable.CreateValueFromKey(EcmaModule) + 0x35
         at Internal.TypeSystem.LockFreeReaderHashtable`2.CreateValueAndEnsureValueIsInTable(TKey) + 0x14
         at ILCompiler.SubstitutionProvider.GetSubstitution(MethodDesc) + 0x78
         at ILCompiler.SubstitutedILProvider.GetMethodIL(MethodDesc) + 0x20
         at ILCompiler.Compilation.CombinedILProvider.GetMethodIL(MethodDesc) + 0x1f
         at ILCompiler.Compilation.ILCache.CreateValueFromKey(MethodDesc) + 0x3a
         at Internal.TypeSystem.LockFreeReaderHashtable`2.CreateValueAndEnsureValueIsInTable(TKey) + 0x14
         at ILCompiler.Compilation.GetMethodIL(MethodDesc) + 0xc0
         at Internal.IL.ILImporter..ctor(ILScanner, MethodDesc, MethodIL) + 0x5a
         at ILCompiler.ILScanner.CompileSingleMethod(ScannedMethodNode) + 0x43
         --- End of inner exception stack trace ---
         at ILCompiler.ILScanner.CompileSingleMethod(ScannedMethodNode) + 0x116
         at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker&, Int64, Boolean&) + 0x118
      --- End of stack trace from previous location ---
         at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker&, Int64, Boolean&) + 0x51b
         at System.Threading.Tasks.TaskReplicator.Replica.Execute() + 0x8d
         --- End of inner exception stack trace ---
         at System.Threading.Tasks.TaskReplicator.Run[TState](TaskReplicator.ReplicatableUserAction`1, ParallelOptions, Boolean) + 0x2bf
         at System.Threading.Tasks.Parallel.ForWorker[TLocal,TInt](TInt, TInt, ParallelOptions, Action`1, Action`2, Func`4, Func`1, Action`1) + 0x1f2
      --- End of stack trace from previous location ---
         at System.Threading.Tasks.Parallel.ThrowSingleCancellationExceptionOrOtherException(ICollection, CancellationToken, Exception) + 0x31
         at System.Threading.Tasks.Parallel.ForWorker[TLocal,TInt](TInt, TInt, ParallelOptions, Action`1, Action`2, Func`4, Func`1, Action`1) + 0x407
         at ILCompiler.ILScanner.CompileMultiThreaded(List`1) + 0x201
         at ILCompiler.ILScanner.ComputeDependencyNodeDependencies(List`1) + 0x16f
         at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() + 0xa1
         at ILCompiler.ILScanner.ILCompiler.IILScanner.Scan() + 0x4ba
         at ILCompiler.Program.<Run>g__RunScanner|4_0(Program.<>c__DisplayClass4_0&) + 0x21f
         at ILCompiler.Program.Run() + 0x278d
         at ILCompiler.ILCompilerRootCommand.<>c__DisplayClass249_0.<.ctor>b__0(ParseResult) + 0x326

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky is this a known issue? I think I already saw this at least once in another PR here.

We had a GC hole that was showing up around this stack trace. I fixed it in dotnet/runtime#111011. The fix will only get picked up when dotnet/runtime repo picks up a new dotnet/sdk (the ILC that's crashing is compiled with an old ILC that doesn't have the fix).

@build-analysis build-analysis bot mentioned this pull request Jan 13, 2025
Open
3 tasks
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 13, 2025 •
edited
Loading

Thanks for the explanation. I submitted dotnet/arcade#15404 to update the SDK throughout the stack.

@ViktorHofer ViktorHofer mentioned this pull request Jan 13, 2025
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
53d43ec 
…0250113.9

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.25061.1 -> To Version 10.0.0-alpha.2.25063.9
@build-analysis build-analysis bot mentioned this pull request Jan 14, 2025
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
76d3797 
…0250113.10

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.25061.1 -> To Version 10.0.0-alpha.2.25063.10
This was referenced Jan 14, 2025
Open
Open
dotnet-maestro bot and others added 6 commits January 14, 2025 05:38
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
5bba150 
…0250113.11

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.25061.1 -> To Version 10.0.0-alpha.2.25063.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
8eaeba0 
…0250114.1

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-alpha.2.25061.1 -> To Version 10.0.0-alpha.2.25064.1
@ViktorHofer
Delete src/SourceBuild/patches/aspnetcore/0001-update-jdk-version.patch
a1b38c6
@ViktorHofer
Revert "Delete src/SourceBuild/patches/aspnetcore/0001-update-jdk-ver…
190f1f0 
…sion.patch"

This reverts commit a1b38c6.
@ViktorHofer
Merge remote-tracking branch 'origin/main' into darc-main-14c3ab0e-1a…
da9ca4d 
…d1-4b34-8fcb-c973140a539f
@ViktorHofer
Remove 0002-Enable-building-Hosting-Bundle-in-VMR patch
f129f17
@ViktorHofer ViktorHofer merged commit 5826ca5 into main Jan 14, 2025
38 of 42 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-14c3ab0e-1ad1-4b34-8fcb-c973140a539f branch January 14, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-wuzhai @ViktorHofer @MichalStrehovsky