[main] Update dependencies from dotnet/arcade #46021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
This was referenced Jan 16, 2025
Open
|
Some of the failures when updating to a newer .NET SDK: cc @javiercn @dotnet/templating-engine-maintainers I'm surprised that many of these failures only show upgrading the toolset SDK. I.e. I would have expected the wpf TFM failure to show up when the TFM got changed in the wpf repository and the changed flowed into sdk. Same for the custom usings one. Are we sure that we are testing consistently with the live sdk? |
|
I think #46164 needs to go in, before this PR gets unblocked. |
…115.4 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25065.4
…116.1 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25066.1
…117.3 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25067.3
…120.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25070.2
…121.3 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25071.3
…122.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25072.2
…-file-publishing-if-possib.patch
javiercn
force-pushed
the
darc-main-533dd42c-2566-45a1-8ce5-710765af532c
branch
from
5f135d3 to
bd0621b
Compare
|
@javiercn why are force-pushing into this PR? That isn't necessary. The PR also already was up-to-date with HEAD and the new SDK. |
|
@ViktorHofer I did not push to it, I did an update with rebase from the GH UI |
|
OK, got it. The rebase from the UI is the same as a force push as it rewrites history. It would be better to not use the rebase strategy but the merge option (same button but different option) in dependency flow PRs in the future. |
|
Btw from what I saw in the previous run, the issue still persists but we should soon know more. |
|
@ViktorHofer I'll keep an eye on it. |
|
|
@ViktorHofer that one is different from what I've seen. I'm taking a look. |
|
@ViktorHofer I think I've found the issue and I'm running the tests locally to verify. It's a change in test expectations because of a packaging change that we did for 10.0. I'm tweaking things a bit to limit the scope of the change and I'm updating the test expectations where needed. We had plans to tweak this logic in the future, but I guess no better time than the present :) |
|
Pushed a few fixes. I don't think everything is fixed just yet, but want to see how much is left |
3 tasks
…123.5 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25072.2 -> To Version 10.0.0-beta.25073.5
…33dd42c-2566-45a1-8ce5-710765af532c
|
@ViktorHofer as far as I can tell all the Blazor issues have been resolved, is that the case? (I only see other non-related failures on the PR) |
ViktorHofer
approved these changes
Jan 24, 2025
ViktorHofer
deleted the
darc-main-533dd42c-2566-45a1-8ce5-710765af532c
branch
|
Thanks for your help @javiercn. You might want to file a follow-up issue to track adding tests for those scenarios at insertion time instead of add SDK update time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade