Append _Attempt$(System.JobAttempt) to artifact name on failure
#46064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jkoritzinsky
approved these changes
Jan 16, 2025
MichaelSimons
approved these changes
Jan 16, 2025
Co-authored-by: Michael Simons <[email protected]>
ViktorHofer
approved these changes
Jan 17, 2025
mthalman
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Looking at the build results, it looks confusing why there are two Publish Artifact steps showing up with only one of them getting executed. I added some suggested display names to make that more clear.
I really like this pattern you've used. It ensures that artifacts only get uploaded once for either scenario (success or failure).
Co-authored-by: Matt Thalman <[email protected]>
Co-authored-by: Matt Thalman <[email protected]>
Co-authored-by: Matt Thalman <[email protected]>
Co-authored-by: Matt Thalman <[email protected]>
Co-authored-by: Matt Thalman <[email protected]>
mthalman
approved these changes
Jan 17, 2025
MichaelSimons
approved these changes
Jan 17, 2025
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4829
This PR breaks the
Publish Artifactsstep into two separate steps:$(Agent.JobName)_Artifacts.$(Agent.JobName)_Artifacts_Attempt$(System.JobAttempt).These changes allow for the artifacts to still be published on success or failure, and these changes prevent the failure described in dotnet/source-build#4829