Fix regression in SBRP usage report #46270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
MichaelSimons
force-pushed
the
fix-sbrp-report
branch
from
e95779f to
c313a7c
Compare
mthalman
approved these changes
Jan 24, 2025
NikolaMilosavljevic
approved these changes
Jan 24, 2025
|
Merging on red as this only affects the SB legs which passed. |
This was referenced Jan 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WriteSbrpUsageReport task was failing to find any project.assets.jsons files due to the changes made in #46208. This resulted in a report that listed all SBRP packages as unreferenced. As part of the fix, additional error checks were added to help prevent regressions like this in the future.