Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #763

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 7, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 6947afa9-ca9b-4946-8288-08d8e9754760
  • Build: 20230811.1
  • Date Produced: August 11, 2023 2:38:05 PM UTC
  • Commit: 9b2af35a6702526dc8a7c5fcadcc44efd0dca170
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates tools.dotnet to 8.0.100-preview.7.23376.3

…804.2

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23371.1 -> To Version 8.0.0-beta.23404.2
@mthalman
Copy link
Member

mthalman commented Aug 7, 2023

Getting build errors like this:

##[error]artifacts/source-build/self/src/src/referencePackages/src/microsoft.codeanalysis.csharp/3.11.0/lib/netstandard2.0/Microsoft.CodeAnalysis.CSharp.cs(191,26): error CS0534: 'CSharpCommandLineParser' does not implement inherited abstract member 'CommandLineParser.GenerateErrorForNoFilesFoundInRecurse(string, IList<Diagnostic>)' [/__w/1/s/artifacts/source-build/self/src/src/referencePackages/src/microsoft.codeanalysis.csharp/3.11.0/Microsoft.CodeAnalysis.CSharp.3.11.0.csproj::TargetFramework=netstandard2.0]

This GenerateErrorForNoFilesFoundInRecurse member being referred to doesn't even exist in the SBRP sources. So apparently, it's compiling against something that's getting loaded in?

@mthalman
Copy link
Member

mthalman commented Aug 7, 2023

Pretty sure this is caused by the changes in dotnet/arcade#13935. I think it's due to this change:

https://github.com/dotnet/arcade/pull/13935/files#diff-2eb72faa78c591f0636156c35835ee8ea4a72f6f0c1a592146892315c4dd8df2L51-R49

It's causing this:

AddSourceToNuGetConfig
    Assembly = /__w/1/s/artifacts/source-build/self/package-cache/microsoft.dotnet.arcade.sdk/8.0.0-beta.23404.2/tools/net8.0/Microsoft.DotNet.Arcade.Sdk.dll
    Parameters
        NuGetConfigFile = /__w/1/s/artifacts/source-build/self/src/NuGet.config
        SourcePath = /__w/1/s/artifacts/source-build/self/src/artifacts/source-build/self/src/artifacts/obj/source-built-upstream-cache/
        SourceName = source-build-int-nupkg-cache

That SourcePath doesn't look right. In a working build, that path is /__w/1/s/artifacts/source-build/self/src/artifacts/obj/source-built-upstream-cache/.

@mmitche - Can you PTAL?

…811.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23371.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro dotnet-maestro bot merged commit 45f5554 into main Aug 14, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-4516b51a-2f25-49a7-9f67-8e8cc83b16c5 branch August 14, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant