Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETSDK1195 error when building runtime in bootstrapping stage 2 build leg #3490

Closed
mthalman opened this issue Jun 1, 2023 · 5 comments
Closed
Assignees
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@mthalman
Copy link
Member

mthalman commented Jun 1, 2023

/vmr/.dotnet/sdk/8.0.100-preview.6.23301.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1195: Unable to optimize assemblies for size: a valid runtime package was not found. Either set the PublishTrimmed property to false, or use a supported target framework when publishing. [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj]

Example build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2192289&view=logs&j=4cede3bc-29a7-5d91-52ef-402f98629c03&t=dd97ae34-3027-5020-e259-ff298adf2f8e (internal link)

@mthalman
Copy link
Member Author

mthalman commented Jun 1, 2023

This is caused by the changes in dotnet/sdk#32045

@mthalman
Copy link
Member Author

mthalman commented Jun 1, 2023

@sbomer - To investigate, here's the link for the runtime binlog.

@sbomer
Copy link
Member

sbomer commented Jun 1, 2023

This failure happens whenever the SDK tries to reference an ILLink pack that isn't supported for the target TFM. It could be caused by the line mentioned in dotnet/sdk#32045 (comment). When runtime picks up an SDK with my change, it needs to change the property name from _IsTrimmingEnabled to _RequiresILLinkPack.

Are there repro steps I can try out to validate a fix?

@sbomer
Copy link
Member

sbomer commented Jun 8, 2023

Should be fixed with dotnet/runtime#87071. I'll leave this open until the fix is confirmed in source-build.

@MichaelSimons
Copy link
Member

The fix flowed in with dotnet/installer#16621.

@github-project-automation github-project-automation bot moved this from Blocked to Done in .NET Source Build Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-upstream-fix Needs a change in a contributing repo
Projects
Archived in project
Development

No branches or pull requests

3 participants