Add a source-build smoke test for native debug symbols #16488

omajid · 2023-05-23T21:49:21Z

This test runs file to find ELF binaries, and then eu-readelf against it to find if all the indicators for native debug symbols are present.

The technique was explained to me by Mark Wielaard ages ago.

This test currently fails. It will continue to fail until dotnet/sdk-container-builds#440 is fixed.

Contributes to dotnet/source-build#3462

omajid · 2023-05-24T15:54:55Z

Hm, tests are failing because mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream8 (https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/centos/stream8/Dockerfile) doesn't have file and elfutils. Should I update the existing buildtools dockerfile for CentOS Stream 8? Or should I create something specific for our testing scenario?

MichaelSimons · 2023-05-25T16:10:53Z

IMO, these dependencies should be added to build buildtools-prereqs container.

The dependencies are needed by dotnet/installer#16488

omajid · 2023-05-27T02:13:25Z

Test is working correctly now and fails due to dotnet/sdk-container-builds#440

MichaelSimons

@baronfel - is dotnet/sdk-container-builds#440 something that will be fixed soon? If not, @omajid, what do you think about adding an exclusion for containerize so that we can merge this PR to ensure no more regressions are submitted.

MichaelSimons · 2023-05-30T17:51:02Z

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/DebugTests.cs

+            }
+        }
+
+        Assert.False(foundIssue);


The UX when the Assert fails requires the user to wade through the test output to find the source of the failure. This is a bit burdensome. This could be improved by capturing the issues in a StringBuilder variable and including it in the userMessage of the Assert.False method.

MichaelSimons · 2023-05-30T17:59:49Z

src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/DebugTests.cs

+
+    private ScanResult ScanFile(string fileName)
+    {
+        string readelfSStdOut = ExecuteHelper.ExecuteProcessValidateExitCode("eu-readelf", $"-S {fileName}", OutputHelper);


I see eu-readelf and file were added utils to the centos stream 8 image in dotnet/dotnet-buildtools-prereqs-docker@b15dff8. This dependency is going to be required for all of the other distros/images we run in CI - https://github.com/dotnet/installer/blob/main/eng/pipelines/templates/stages/vmr-build.yml#L16.

This leads me to think we should document these native dependencies in the test's readme - https://github.com/dotnet/installer/blob/main/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/README.md

baronfel · 2023-05-30T18:09:12Z

@MichaelSimons there's a PR by @vlada-shubina that should solve it, just gotta get it green

omajid · 2023-06-12T19:09:20Z

Not sure where this error is coming from:

    /vmr/.dotnet/sdk/8.0.100-preview.6.23312.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1195: Trimming, or code compatibility analysis for trimming, single-file deployment, or ahead-of-time compilation is not supported for the target framework. For more information, see https://aka.ms/netsdk1195 [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj]

I filed #16648 to update Fedora 36 to Fedora 38, and the Fedora 38 containers include file and eu-readelf utilities.

mthalman · 2023-06-12T19:21:23Z

@eerhardt - See #16488 (comment)

eerhardt · 2023-06-12T19:32:48Z

@sbomer any idea on the above error?

error NETSDK1195: Trimming, or code compatibility analysis for trimming, single-file deployment, or ahead-of-time compilation is not supported for the target framework. For more information, see https://aka.ms/netsdk1195 [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj]

@mthalman @omajid - is there a binlog of the build with this error?

sbomer · 2023-06-12T20:01:58Z

It's the same error that came up in dotnet/source-build#3490 - which if the root cause is the same should be fixed by dotnet/runtime#87071. Is that runtime fix included in the bits which produced the error?

mthalman · 2023-06-12T20:28:27Z

It's the same error that came up in dotnet/source-build#3490 - which if the root cause is the same should be fixed by dotnet/runtime#87071. Is that runtime fix included in the bits which produced the error?

Oh yes, sorry about that. @omajid, these errors are expected currently in the main branch. Should be resolved once #16621 gets merged and incorporated in the VMR.

omajid · 2023-06-19T15:06:27Z

This is a new error:

MSBUILD : error MSB1021: Cannot create an instance of the logger. Microsoft.Build.BackEnd.Logging.CentralForwardingLogger Could not load type of field 'Microsoft.Build.Shared.TypeLoader:_context' (4) due to: Could not load file or assembly 'System.Reflection.MetadataLoadContext, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.

Anyone seen this before?

MichaelSimons · 2023-06-19T15:41:53Z

This is a new error:

MSBUILD : error MSB1021: Cannot create an instance of the logger. Microsoft.Build.BackEnd.Logging.CentralForwardingLogger Could not load type of field 'Microsoft.Build.Shared.TypeLoader:_context' (4) due to: Could not load file or assembly 'System.Reflection.MetadataLoadContext, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.

Anyone seen this before?

This same error is appearing in dotnet/source-build#3528 when building smoke-tests

MichaelSimons · 2023-06-22T16:30:06Z

The VMR Source-Build Fedora38_Offline_CurrentSourceBuiltSdk_x64 leg is failing because of dotnet/source-build#3515.

MichaelSimons · 2023-08-08T18:46:34Z

@omajid, looks like the tests passed. When convenient, revert the changes to validate in PR validation.

This test runs `file` to find ELF binaries, and then `eu-readelf` against it to find if all the indicators for native debug symbols are present. The technique was explained to me by Mark Wielaard ages ago. This test currently fails. It will continue to fail until dotnet/sdk-container-builds#440 is fixed. Contributes to dotnet/source-build#3462

omajid requested a review from a team as a code owner May 23, 2023 21:49

MichaelSimons added the Area-SourceBuild label May 24, 2023

omajid added a commit to omajid/dotnet-buildtools-prereqs-docker that referenced this pull request May 25, 2023

Add additional test deps to CentOS Stream 8 dockerfile

9005b73

The dependencies are needed by dotnet/installer#16488

omajid mentioned this pull request May 25, 2023

Add additional test deps to CentOS Stream 8 dockerfile dotnet/dotnet-buildtools-prereqs-docker#875

Merged

omajid force-pushed the source-build-smoke-test-debugging branch from 70332ee to ce5bfc5 Compare May 26, 2023 15:37

MichaelSimons reviewed May 30, 2023

View reviewed changes

omajid force-pushed the source-build-smoke-test-debugging branch 10 times, most recently from 4ef5517 to 050cd97 Compare June 7, 2023 14:19

omajid force-pushed the source-build-smoke-test-debugging branch from 050cd97 to ffe4d74 Compare June 12, 2023 16:21

omajid force-pushed the source-build-smoke-test-debugging branch from 35f01ff to f4e4dfd Compare July 13, 2023 18:16

omajid force-pushed the source-build-smoke-test-debugging branch 2 times, most recently from 1a48b13 to f00fee1 Compare July 19, 2023 14:33

omajid force-pushed the source-build-smoke-test-debugging branch from e9afb75 to db9fc52 Compare August 8, 2023 22:55

mthalman approved these changes Aug 9, 2023

View reviewed changes

MichaelSimons approved these changes Aug 9, 2023

View reviewed changes

MichaelSimons merged commit c796ecb into dotnet:main Aug 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a source-build smoke test for native debug symbols #16488

Add a source-build smoke test for native debug symbols #16488

omajid commented May 23, 2023 •

edited

Loading

omajid commented May 24, 2023

MichaelSimons commented May 25, 2023

omajid commented May 27, 2023

MichaelSimons left a comment

MichaelSimons May 30, 2023

MichaelSimons May 30, 2023

baronfel commented May 30, 2023

omajid commented Jun 12, 2023

mthalman commented Jun 12, 2023

eerhardt commented Jun 12, 2023

sbomer commented Jun 12, 2023

mthalman commented Jun 12, 2023

omajid commented Jun 19, 2023

MichaelSimons commented Jun 19, 2023

MichaelSimons commented Jun 22, 2023

MichaelSimons commented Aug 8, 2023

Add a source-build smoke test for native debug symbols #16488

Add a source-build smoke test for native debug symbols #16488

Conversation

omajid commented May 23, 2023 • edited Loading

omajid commented May 24, 2023

MichaelSimons commented May 25, 2023

omajid commented May 27, 2023

MichaelSimons left a comment

Choose a reason for hiding this comment

MichaelSimons May 30, 2023

Choose a reason for hiding this comment

MichaelSimons May 30, 2023

Choose a reason for hiding this comment

baronfel commented May 30, 2023

omajid commented Jun 12, 2023

mthalman commented Jun 12, 2023

eerhardt commented Jun 12, 2023

sbomer commented Jun 12, 2023

mthalman commented Jun 12, 2023

omajid commented Jun 19, 2023

MichaelSimons commented Jun 19, 2023

MichaelSimons commented Jun 22, 2023

MichaelSimons commented Aug 8, 2023

omajid commented May 23, 2023 •

edited

Loading