Longstanding Intellisense bug

[jrieken]

From @Figbash on April 29, 2016 17:30

Will somebody please give this bug some attention? There are many of us that haven't been able to move from version 0.10.3 in December. I would very much like to run an up to date version of VSCode.

OmniSharp/omnisharp-roslyn#371
#6

Copied from original issue: microsoft/vscode#5993

[VinditCo]

This bug is still in the latest release. Any updates?

[VinditCo]

Sorry to chase @jrieken, but do you guys have any kind of ETA on this? Is there anything we can do to help diagnose the issue? Cheers

[misnor]

I am also experiencing painfully slow, if non existent intellisense support on VS Code running in a Ubuntu VM.

The project having issues is just a blank .NET Console application - typing "args." does nothing, and hitting ctrl+space pops open the "Loading..." and sometimes it loads.

Attached is my VSCode output.

omnisharp.txt

[jrieken]

@DustinCampbell will know

[Figbash]

Honestly I have given up on this being looked at, I even emailed dustin directly offering to help figure it out and got no response. There doesn't seem to be any interest in making C# functional again ever since this was split into a separate plugin :( It's very frustrating, as it worked so perfectly before that.

@VinditCo My gut feeling is that it has something to do with either precompiled DLL plugins or just very large projects, as it doesn't seem to occur on any of my simpler projects. I have been trying to narrow it down so at least we could pull offending files out of the solution to allow us to work, but I have not had any luck. I will let you know if I ever find anything that helps.

[DustinCampbell]

@Figbash -- don't give up hope! I actually never received your email.

The OmniSharp log you provided indicated that you're using a project.json-based project. Is this a project targeting ASP .NET RC1 (e.g. DNX), or a newer .NET CLI project?

[VinditCo]

@DustinCampbell thanks for getting back to us! I'm running Unity 5.3.4p5 - how would I check if it's using a json-based project?

[Figbash]

@DustinCampbell I apologize for venting, I sent the email a couple weeks ago. I am running Unity as well and believe the problem generally affects Unity projects (I'm thinking misnor has a different issue).
Unity targets Mono that is equivalent to .NET 2.

The startup log in version .10.3 of VSCode always shows:
[INFORMATION:OmniSharp.Dnx.DnxPaths] Using runtime '/Users/raymondbritton/.dnx/runtimes/dnx-mono.1.0.0-beta4'.
[INFORMATION:OmniSharp.Dnx.DnxProjectSystem] Scanning 'AJMobile_Trunk' for DNX projects
[INFORMATION:OmniSharp.Dnx.DnxProjectSystem] No project.json based projects found

The solution file/csproj files seem to be an XML format for visual studio 12 rather than JSON.
I have uploaded the solution from my broken project:
Assembly.zip
The solution files are generated by Unity.

[DustinCampbell]

Sorry, I was looking at the OmniSharp log that @misnor posted -- that one is project.json-based. I'll take a look at the project you provided.

[Figbash]

I'm not entirely sure if the output log is even related, I often get the same issue without the log appearing.
For instance I have just used command click on to jump around some files in VSCode 1.1.0-insider, and did not receive any logs in output. The first few jumps were quick, but the third one brings up the "Loading..." tooltip for around 6 seconds before working again, and there was nothing in the output besides:
[INFORMATION:OmniSharp.Middleware.LoggingMiddleware] /v2/getcodeactions: 200 627ms

I did get this in the output a little before the slowdown:
[INFORMATION:OmniSharp.ScriptCs.ScriptCsProjectSystem] Detecting CSX files in '/Users/raymondbritton/Desktop/AJMobile_Trunk'.
[INFORMATION:OmniSharp.ScriptCs.ScriptCsProjectSystem] Could not find any CSX files
[INFORMATION:OmniSharp.Startup] Solution has finished loading
[ERROR:Microsoft.AspNet.Diagnostics.ErrorHandlerMiddleware] An unhandled exception has occurred: Diagnostic must have span '[1505..1505)'
Parameter name: diagnostics
System.ArgumentException: Diagnostic must have span '[1505..1505)'
Parameter name: diagnostics
at Microsoft.CodeAnalysis.CodeFixes.CodeFixContext.VerifyDiagnosticsArgument (ImmutableArray1 diagnostics, TextSpan span) [0x00000] in <filename unknown>:0 at Microsoft.CodeAnalysis.CodeFixes.CodeFixContext..ctor (Microsoft.CodeAnalysis.Document document, TextSpan span, ImmutableArray1 diagnostics, System.Action2 registerCodeFix, Boolean verifyArguments, CancellationToken cancellationToken) [0x00000] in <filename unknown>:0 at Microsoft.CodeAnalysis.CodeFixes.CodeFixContext..ctor (Microsoft.CodeAnalysis.Document document, TextSpan span, ImmutableArray1 diagnostics, System.Action2 registerCodeFix, CancellationToken cancellationToken) [0x00000] in <filename unknown>:0 at OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.CodeActionHelper+<GetCodeFixContext>d__2.MoveNext () [0x00000] in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter1[System.Nullable1[Microsoft.CodeAnalysis.CodeFixes.CodeFixContext]].GetResult () [0x00000] in <filename unknown>:0 at OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.CodeActionHelper+<GetActions>d__0.MoveNext () [0x00000] in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter1[System.Collections.Generic.IEnumerable1[Microsoft.CodeAnalysis.CodeActions.CodeAction]].GetResult () [0x00000] in <filename unknown>:0 at OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.GetCodeActionsService+<Handle>d__4.MoveNext () [0x00000] in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter1[OmniSharp.Models.V2.GetCodeActionsResponse].GetResult () [0x00000] in :0
at OmniSharp.Middleware.Endpoint.EndpointHandler2+<HandleSingleRequest>d__18[OmniSharp.Models.V2.GetCodeActionsRequest,OmniSharp.Models.V2.GetCodeActionsResponse].MoveNext () [0x00000] in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter1[System.Object].GetResult () [0x00000] in :0
at OmniSharp.Middleware.Endpoint.EndpointHandler2+<Process>d__16[OmniSharp.Models.V2.GetCodeActionsRequest,OmniSharp.Models.V2.GetCodeActionsResponse].MoveNext () [0x00000] in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in <filename unknown>:0 at System.Runtime.CompilerServices.TaskAwaiter1[System.Object].GetResult () [0x00000] in :0
at OmniSharp.Middleware.EndpointMiddleware+d__7.MoveNext () [0x00000] in :0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00000] in :0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00000] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00000] in :0
at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in :0
at Microsoft.AspNet.Diagnostics.ErrorHandlerMiddleware+d__4.MoveNext () [0x00000] in :0

[DustinCampbell]

Hmmm... Could you try this? Grab the latest omnisharp.linux-mono.tar.gz from https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/v1.9-alpha13 and untar it to a directory. Then, set the "csharp.omnisharp" preference in VS Code to point to "/directory/you/just/created/OmniSharp.exe". Restart VS Code and see if this addresses the issue.

[Figbash]

I am running OSX BTW. Attempting to do what you said shows:
/Users/raymondbritton/Desktop/omnisharp-linux-mono/OmniSharp.exe: cannot execute binary file

[DustinCampbell]

:grumble: ok. Give me a day or two to get set up to try and repro. If you have anymore you could share to reproduce the problem that'd be helpful.

[DustinCampbell]

Note that I've never actually installed Unity before so this is new territory for me 😊

[Figbash]

Ok, thank you. I cannot share the project unfortunately as it is my companies and is enormous, perhaps @VinditCo has something shareable? If it would help figure it out I would be willing to screen share.

I have gotten the alpha to start using a bash script with mono OmniSharp.exe, but it gives me:
[INFO] Starting OmniSharp at '/Users/raymondbritton/Desktop/AJMobile_Trunk/AJMobile_Trunk.sln'...
[INFO] Started OmniSharp from '/Users/raymondbritton/Desktop/omnisharp-linux-mono/omnisharp' with process id 17707...
OmniSharp:
info: OmniSharp.Startup[0]
Omnisharp server running on port '2000' at location '/Users/raymondbritton/Desktop/AJMobile_Trunk' on host -1.
info: OmniSharp.DotNet.DotNetProjectSystem[0]
Initializing in /Users/raymondbritton/Desktop/AJMobile_Trunk
info: OmniSharp.DotNet.DotNetProjectSystem[0]
Auto package restore: True
fail: OmniSharp.Startup[0]
The project system 'DotNetProjectSystem' threw exception during initialization.
Failed to initialize Microsoft.DotNet.ProjectModel.WorkspaceContext at /Users/raymondbritton/Desktop/AJMobile_Trunk.
at OmniSharp.DotNet.DotNetProjectSystem.Initalize (IConfiguration configuration) [0x00000] in :0
at OmniSharp.Startup.Configure (IApplicationBuilder app, IServiceProvider serviceProvider, IOmnisharpEnvironment env, ILoggerFactory loggerFactory, ISharedTextWriter writer, IOmnisharpAssemblyLoader loader, IOptions`1 optionsAccessor) [0x00000] in :0
info: OmniSharp.MSBuild.MSBuildProjectSystem[0]
Detecting projects in '/Users/raymondbritton/Desktop/AJMobile_Trunk/AJMobile_Trunk.sln'.
info: OmniSharp.MSBuild.MSBuildProjectSystem[0]
Loading project from '/Users/raymondbritton/Desktop/AJMobile_Trunk/Assembly-CSharp-firstpass.csproj'.
info: OmniSharp.MSBuild.MSBuildProjectSystem[0]
Loading project from '/Users/raymondbritton/Desktop/AJMobile_Trunk/Assembly-CSharp.csproj'.
info: OmniSharp.MSBuild.MSBuildProjectSystem[0]
Loading project from '/Users/raymondbritton/Desktop/AJMobile_Trunk/Assembly-CSharp-Editor-firstpass.csproj'.
info: OmniSharp.MSBuild.MSBuildProjectSystem[0]
Loading project from '/Users/raymondbritton/Desktop/AJMobile_Trunk/Assembly-CSharp-Editor.csproj'.
info: OmniSharp.ScriptCs.ScriptCsProjectSystem[0]
Detecting CSX files in '/Users/raymondbritton/Desktop/AJMobile_Trunk'.
info: OmniSharp.ScriptCs.ScriptCsProjectSystem[0]
Could not find any CSX files
info: OmniSharp.Startup[0]
Configuration finished.
[ERROR] Error: Failed to start OmniSharp

If you have any ideas on that exception I can try again.

[DustinCampbell]

OK. I'm also adding @troydai, who might have some ideas as well. It seems suspicious that the DotNetProjectSystem is throwing. Do you have project.json files in your project at all?

[Figbash]

I can walk you through Unity:
Install Unity Free, tell it to include the demo project
Open the demo project in Unity
Grab https://github.com/dotBunny/VSCode and put it under the demo project dir /Assets/Editor
In Unity open Assets menu, Open C# Project In Code
This will generate the solution and open it in Code.
Then just try using it a little bit and the issue will either be very apparent or the demo project won't have the issue, hopefully the former :)

I don't see any project.json files in the project.

[VinditCo]

I'm also on OSX and don't have any project.json files. Sadly I also cant post a copy of the project.
Are there any logs you'd like me to post?

[Figbash]

I am trying to reproduce this on a smaller project but I'm not having any luck. It definitely seems to have something to do with project size or complexity...

[DustinCampbell]

Good to know. I'm still looking at this. Thanks for the update!

[VinditCo]

I also think it's something to do with the project size. Perhaps something to do with 3rd party DLL's? @Figbash are you using much from the Asset Store?

[Taugeshtu]

Small-ish by itself project in unity with EmguCV's managed part in source files copied to project broke omnisharp for me. We're talking about 400 classes there. Once it's all compiled to class library, however, issue is gone.

[VinditCo]

@Taugeshtu when you say 'compiled to class library' are you referring to the recompile VSCode triggers on code change? If so, that's the same me :)

[Taugeshtu]

@VinditCo No, I'm referring to "pack all those classes into managed .dll"

[VinditCo]

@DustinCampbell Hello! Did you have any success looking into this?

[DustinCampbell]

We've been focused on getting Unity support back up and running in the C# extension (note the breaking change on our readme. Once that is working again, I'll be taking a look at the performance and flakiness of IntelliSense. Sorry for the delay!

[DustinCampbell]

@Figbash, @nixbb: I just wanted to let you know that I dug into the issue and it appears that the VS Code diagnostic system doesn't scale as well as it should, especially in the scenario where there are lots of files containing at least 1 diagnostic. I've produced a repro and filed an issue for the VS Code folks to take a look at here: microsoft/vscode#11976.

[DustinCampbell]

The VS Code team has dug into microsoft/vscode#11976 and has fixes that should address this problem. Hopefully, we'll see improvements soon when it comes down the VS Code Insiders channel.

[DustinCampbell]

Hey all -- VS Code 1.6 is out and includes performance fixes that should fix this issue. Are folks still experiencing this issue with the latest VS Code release?

[Figbash]

@DustinCampbell I've been using it all week, I haven't experienced any problems. I think it's fixed.

[DustinCampbell]

w00t! Note that there was also a problem with diagnostics not getting reported properly with VS Code 1.6 that has also been fixed in the latest C# extension beta.

[nixbb]

Excellent work, I've used 1.6.x for a week now and the slow down issues I was experiencing seems to be solved. The duplicates entries are gone as well.

Thank you.

[heyalistair]

These improvements optimizations sound really impressive...

... but I'm now getting some other problems with Intellisense when I try to use VSCode and Unity. I only have ~1 second to see and correct any errors before they disappear from the screen. Here is a gif:

I'm going to try and gather some more information, try out some other Unity projects, and then I will open up another issue. In the meantime, I thought I would mention it here in case it is related to the update and others wanted to chime in.

[ChicK00o]

Ohh yes this is an issue with every unity project that has any plugins in it. the hints and suggestion take a lot of time to show up. more over changing anything in the file results in re counting of references across the file [the reference count that is shown above every method and variable]

[Figbash]

@heyalistair I doubt this is helpful, but I am not experiencing this at all with multiple problematic Unity projects :)

[heyalistair]

@ChicK00o Actually hints and suggestions don't really take much time to show up at all, everything seems super fast thanks to the work that was put in on this issue. It's just that these error keep disappearing!

When I switch back to VSCode 1.5.3, the errors stay on the screen like they should. It's something that I am experiencing only in 1.6.x. In 1.6.x, I only have two plugins installed C# 1.4.1 and Mono Debug 0.11.0.

@Figbash Thanks! Any info is helpful, no matter how envy-inducing. :)

[perfectsquircle]

@heyalistair I am seeing the exact same behavior. I'm using 1.6.1, working in a .NET Core project, any errors disappear after about a second. I don't know how to fix it, but it's been extremely frustrating. Have you found a workaround other that downgrading to 1.5?

[DustinCampbell]

@perfectsquircle: This should be fixed by install 1.5-beta4 of the C# extension from here. Once you have it downloaded, installing it is pretty easy:

1. In VS Code, select View->Extensions from the menu to open the Extensions pane.
2. At the top-right corner of the Extension pane, click the [...] and select "Install from VSIX..."
3. Locate the file you downloaded.

[perfectsquircle]

@DustinCampbell I'm trying out 1.5-beta4 now and it appears to have fixed my issue! Thanks for your quick response, this problem has been puzzling me for the last couple of weeks. I hope 1.5.0 goes live soon.

[DustinCampbell]

We're working on it. 😄

[CyanSlinky]

This is still happening for me, intellisense only shows errors for a couple of seconds and then stops working. I'm using version 1.7.1 of VS Code. 2 extensions: "C#" version 1.4.1 and "Mono Debug" version 0.11.0 and Windows 7, I'm working on a new unity project but it seems to not work for any unity project regardless of if it's large or not. I'm also using Unity 5.5.0b8 which is supposed to have inbuilt VS Code support but I've also tried it on 5.4 and it makes no difference. Hopefully this can be properly fixed as it makes it completely unusable at the moment.

[DustinCampbell]

Hi @CyanSlinky, could you try the new 1.5-future-preview1 release and let me know if that helps? Here are instructions to install it cleanly:

1. Open Visual Studio Code
2. Select View->Extensions from the menu to show the Extensions pane.
3. If you have the C# extension already installed, click on the little gear next to it and choose “Uninstall”. Then, allow VS Code to reload.
4. At the top-right corner of the Extensions pane, click the […] and select “Install from VSIX…” and then choose the VSIX you just downloaded.
5. Let VS Code reload.

[DustinCampbell]

OK. I expect this to be greatly improved if not completely fixed in the 1.5 release. I'm going to gasp close this issue. If this continues to be an problem for anyone, let's start a new issue.

[heyalistair]

Hi @DustinCampbell,

I tried the manual install of C# extension you linked to (1.5-future-preview1) and the current release (1.5.2) via the VS Code marketplace, and neither have resolved my issue. I still have disappearing errors. I will try to recreate in a sample project and if I can do that, I will open a new issue.

But anyway, thanks so much for fixing #269. It was epic.

[DustinCampbell]

Thanks a ton @heyalistair. The disappearing errors issue has been a bit of a thorn in my side because I've not been able to reproduce yet.

[BrianHubble]

This was bothering me in Visual Studio Code working with Unity but I'd say check that you do not still have the "Legacy C#" extension installed. I uninstalled both and reinstalled the normal C# extension; the "mono.osx" process (it says this instead of "mono-sgen" for some reason now) still uses a lot of CPU in the ActivityMonitor but the completion problems and delays I had been seeing have gone away.

[DustinCampbell]

It says "mono.osx" because OmniSharp now runs on its own Mono runtime. I'm glad to hear that the delays have gone away. That's fantastic. How much CPU activity are you seeing?

[BrianHubble]

Like, between 60% and 200%. It doesn't seem to slow anything down though, just makes the fan on my MacBook Pro spin kinda loudly.

[DustinCampbell]

yeah, that seems pretty significant. Do you have a particularly large project?

[heyalistair]

@BrianHubble Definitely didn't have the "Legacy C#" extension. Thanks tho.

@DustinCampbell So... I tried to come up with a reproducible project. I started off by making sure I had fresh, recent installs of Unity and the little VSCode plugin by dotbunny and I opened an open source project. But I didn't see the bug there, and everything worked fine.

Then, I switched back to my original configuration (Unity 5.4.1p4 and previous VSCode plugin) and opened my private project, where I usually see the bug. And the bug was not there. Errors do NOT disappear anymore.

Maybe rewriting workspace settings helped? (In Unity -> Preferences -> VSCode tab -> Write Workspace Settings)
Maybe VSCode was caching something and it finally got cleared?

[heyalistair]

@DustinCampbell Actually, this morning I installed the Visual Studio Preview for Mac that was just announced at Connect()... It looks like it might have bumped my mono version! That might have done it

[DustinCampbell]

FWIW, we just discovered the caused of errors disappearing in larger projects. The necessary fix has been made to VS Code and should hopefully start showing up in VS Code Insiders builds soon. Details are here: microsoft/vscode#15585.

[BrianHubble]

@DustinCampbell It's a fairly large Unity project and the slowness will still come and go. (I should mention it also shows like 99+ errors in VS Code that are not errors in Unity).

Anyway, I will try the Insiders update channel.