-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features to support test adapter extension #3601
Features to support test adapter extension #3601
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
==========================================
+ Coverage 86.92% 89.81% +2.88%
==========================================
Files 59 59
Lines 1805 1590 -215
Branches 208 89 -119
==========================================
- Hits 1569 1428 -141
+ Misses 181 151 -30
+ Partials 55 11 -44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I look forward to trying this out in test explorer. These changes look good to me.
@Samirat Sorry I tried fixing merge conflicts and inadvertently broke the package-lock.json. I can't seem to push changes to the PR branch, but running |
@JoeRobich Thanks for the review. I probably need to check this over before merging anyway, make sure I didn't leave it any test code or anything. I'll take a look and get it ready to go tomorrow. We've been using the test explorer adapter for a while, and it works pretty well. The one thing that would be really nice is test cancellation support, but it seemed like this might be kind of complicated to add right now. |
…mirat/omnisharp-vscode into samirat/test_explorer_adapter
@Samirat Thanks! |
I've been working on a C# adapter for Test Explorer UI. This adds features to OmniSharp to support that.
My adapter: https://github.com/Samirat/omnisharp-test-adapter
In particular this adds:
I've got a separate PR for the runsettings thing, but it was difficult to extract from this branch, so those changes are included here.