Skip to content

Commit

Permalink
Fix TailCallStress mode. (dotnet/runtime#40698)
Browse files Browse the repository at this point in the history
Improve validation of tail calls that are not tail-prefixed in the IL
but are marked as such because of TailCallStress. We now do the same
correctness validation in morph for such tail calls as we do for
implicit tail calls. That blocks tail calls when we have address-taken
locals, struct promoted params, and pinned vars.

Fixes dotnet/runtime#39398.
Fixes dotnet/runtime#39309.
Fixes dotnet/runtime#38892.
Fixes dotnet/runtime#38889.
Fixes dotnet/runtime#38887.
Fixes dotnet/runtime#37117.
Fixes dotnet/runtime#8017.

Commit migrated from dotnet/runtime@7742b57
  • Loading branch information
erozenfeld authored Aug 15, 2020
1 parent 14e179a commit 2c32c88
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/System.Drawing.Common/tests/FontTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,6 @@ public void SizeInPoints_Get_ReturnsExpected(GraphicsUnit unit)
[InlineData(FontStyle.Strikeout | FontStyle.Bold | FontStyle.Italic, 255, true, "@", 700)]
[InlineData(FontStyle.Regular, 0, false, "", 400)]
[InlineData(FontStyle.Regular, 10, false, "", 400)]
[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/38889", RuntimeTestModes.TailcallStress)]
public void ToLogFont_Invoke_ReturnsExpected(FontStyle fontStyle, byte gdiCharSet, bool gdiVerticalFont, string expectedNamePrefix, int expectedWeight)
{
using (FontFamily family = FontFamily.GenericMonospace)
Expand Down Expand Up @@ -818,7 +817,6 @@ public void ToLogFont_Invoke_ReturnsExpected(FontStyle fontStyle, byte gdiCharSe
[InlineData(TextRenderingHint.SingleBitPerPixel)]
[InlineData(TextRenderingHint.SingleBitPerPixelGridFit)]
[InlineData(TextRenderingHint.ClearTypeGridFit)]
[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/38889", RuntimeTestModes.TailcallStress)]
public void ToLogFont_InvokeGraphics_ReturnsExpected(TextRenderingHint textRenderingHint)
{
using (FontFamily family = FontFamily.GenericMonospace)
Expand Down

0 comments on commit 2c32c88

Please sign in to comment.