Move common dialogs to CsWin32 and clean printing #10471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't (yet) directly use CsWin32 directly for the common dialogs due to packing differences between 32 and 64 bit. We target AnyCPU and CsWin32 doesn't have the ability to force a particular platform definition. For now, I'm copying in CsWin32 defines from a platform targetted project. Hopefully we'll eventually get .NET support for specifying packing per platform. Also investigating getting a feature added to CsWin32 to mitigate this for us. This does a pass through all of the print code to clean to style guides. Plan is to follow up with an attempt to update System.Drawing to CsWin32 code.
ghost
assigned 
|
CsWin32 related issue: .NET Runtime related issues: |
Tanya-Solyanik
approved these changes
Dec 13, 2023
| if (text.Length == 0) | ||
| return null; | ||
| } | ||
| else |
There was a problem hiding this comment.
else can be removed because we are returning from the if clause
| { | ||
| if (destinationType == typeof(InstanceDescriptor)) | ||
| if (value is not string strValue) |
| /// </summary> | ||
| public int RawKind | ||
| { | ||
| get => unchecked((int)_kind); | ||
| set => _kind = unchecked((PaperSourceKind)value); | ||
| get => (int)_kind; |
There was a problem hiding this comment.
There are more unchecked keywords that can be removed, but this is an iterative process.
| @@ -1033,18 +917,25 @@ internal unsafe PaperSize[] Get_PaperSizes() | |||
|
|
|||
| int count = FastDeviceCapabilities(SafeNativeMethods.DC_PAPERNAMES, IntPtr.Zero, -1, printerName); | |||
| if (count == -1) | |||
| return Array.Empty<PaperSize>(); | |||
| { | |||
| return []; | |||
|
Thanks, @Tanya-Solyanik. I'll catch your comments in the next PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't (yet) directly use CsWin32 directly for the common dialogs due to packing differences between 32 and 64 bit. We target AnyCPU and CsWin32 doesn't have the ability to force a particular platform definition. For now, I'm copying in CsWin32 defines from a platform targetted project.
Hopefully we'll eventually get .NET support for specifying packing per platform. Also investigating getting a feature added to CsWin32 to mitigate this for us.
This does a pass through all of the print code to clean to style guides.
Plan is to follow up with an attempt to update System.Drawing to CsWin32 code.
Microsoft Reviewers: Open in CodeFlow