Removed build warning in VS #7220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
previously approved these changes
May 26, 2022
|
Looks like dotnet/arcade#4337 is not as fixed as we expected it to be. Reverting that commit. |
JeremyKuhne
reviewed
May 26, 2022
src/System.Windows.Forms.Primitives/tests/UnitTests/Interop/Oleaut32/VARIANTTests.cs
Outdated
Show resolved
Hide resolved
kant2002
added a commit
to kant2002/runtime
that referenced
this pull request
May 31, 2022
I believe this is related to latest changes in Roslyn. Similar to dotnet/winforms#7220
RussKie
reviewed
May 31, 2022
src/System.Windows.Forms.Primitives/tests/UnitTests/Interop/PARAMTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Primitives/tests/UnitTests/Interop/PARAMTests.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
RussKie
approved these changes
May 31, 2022
|
Thank you |
MichalStrehovsky
pushed a commit
to dotnet/runtime
that referenced
this pull request
Jun 1, 2022
I believe this is related to latest changes in Roslyn. Similar to dotnet/winforms#7220
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't build in the latest IntPreview Dev17 without this change.
unchecked- fixes a build break,#pragmasuppression is only a warning.Microsoft Reviewers: Open in CodeFlow