Migrate Shell32 enums to Cswin32
#9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
CC: @lonitra |
JeremyKuhne
reviewed
Sep 14, 2023
| @@ -8,6 +8,6 @@ internal static partial class Interop | |||
| internal static partial class Shell32 | |||
| { | |||
| [DllImport(Libraries.Shell32, CharSet = CharSet.Unicode, ExactSpelling = true)] | |||
There was a problem hiding this comment.
Wouldn't it be better to change this PInvoke over? The defines should come with that, I believe.
There was a problem hiding this comment.
NOTIFYICONDATAW has different versions for different architectures (x86/x64). I wasn't sure how to support that so I left it alone.
There was a problem hiding this comment.
@elachlan Sorry that I missed your response. The right thing to do is move the struct to the same namespace that it would live under CsWin32 and put a reference to the active CsWin32 issue. microsoft/CsWin32#882
There was a problem hiding this comment.
Same for the PInvoke itself
|
@JeremyKuhne anything else I need to address? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates shell32 custom implemented enums to use ones generated from cswin32.
Microsoft Reviewers: Open in CodeFlow