-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes in test repo for making Setter.Value the ContentProperty for Setter #321
Changes from all commits
c3074e8
8416426
8fd4aa6
d92df83
1992161
bd19723
72ac1c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,6 +71,7 @@ | |
<PropertyToSkip PropertyName="LCID" Owner="CultureInfo" /> | ||
<!-- With DWM turned on, Button.BorderBrush changes--> | ||
<PropertyToSkip PropertyName="BorderBrush" Owner="Button" /> | ||
<PropertyToSkip PropertyName="Value" Owner="Setter" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like to understand how we are using the PropertiesToSkip.xaml to skip the properties for the comparison and why are we making a change here. The rationale for the question is that we were checking it earlier and now we are skipping this check, so skipping needs better reasoning. |
||
<!-- Transform.Inverse property always returns a new Transform, thus putting us into an infinite loop --> | ||
<PropertyToSkip PropertyName="Inverse" Owner="Transform" /> | ||
<PropertyToSkip PropertyName="Inverse" Owner="Transform3D" /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not getting the implementation of this function. As of now what I can get is that we are reading the propertiesToSkip.xml and working on that check only. There should be more checks in my understanding to validate if it is a ContentProperty or not.