Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackOverflow due to focus war in RibbonMenuButton #2220

Closed
SamBent opened this issue Nov 20, 2019 · 4 comments
Closed

StackOverflow due to focus war in RibbonMenuButton #2220

SamBent opened this issue Nov 20, 2019 · 4 comments
Assignees
@SamBent
Labels
Bug Product bug (most likely) netfx-servicing-approved Netfx Approved for Servicing Servicing-consider

Comments

@SamBent
Copy link
Contributor

SamBent commented Nov 20, 2019

An app that programmatically disables a RibbonMenuButton and replaces its menu items with new ones can cause a focus war leading to infinite recursion and StackOverflow. This can happen if the user presses the toggle button (which opens the menu dropdown) and drags the mouse over the dropdown, and the programmatic disable/replace occurs before the user releases the mouse button.

[Port of servicing fix for .NET 4.6 - 4.8]
@SamBent SamBent added Bug Product bug (most likely) netfx-servicing-approved Netfx Approved for Servicing labels Nov 20, 2019
@SamBent SamBent self-assigned this Nov 20, 2019
@SamBent SamBent mentioned this issue Feb 23, 2023
Open
@arpitmathur arpitmathur modified the milestones: 5.0, 3.1 Nov 21, 2019
@ghost ghost removed this from the 3.1 milestone Nov 25, 2019
@ghost
Copy link

ghost commented Nov 25, 2019

@dotnet/wpf-developers, It's time to give an update to the community.

1 similar comment
@ghost
Copy link

ghost commented Nov 26, 2019

@dotnet/wpf-developers, It's time to give an update to the community.

@SamBent SamBent mentioned this issue Dec 2, 2019
Merged
@ghost
Copy link

ghost commented Jan 27, 2020

@dotnet/wpf-developers, It's time to give an update to the community.

@SamBent
Copy link
Contributor Author

SamBent commented Jan 27, 2020

For .NET 4.6+, the fix has been released for many OS (others to follow this week). For details see the announcement.
For .NET Core 3.1.2, the fix is PR #2269.

@SamBent SamBent closed this as completed Jan 27, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SamBent SamBent

Labels
Bug Product bug (most likely) netfx-servicing-approved Netfx Approved for Servicing Servicing-consider
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arpitmathur @SamBent