Ribbon focus war #2269
Merged
Ribbon focus war #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamBent
added
netfx-servicing-approved
ghost
requested review from
ghost
added
the
vatsan-madhavan
approved these changes
Dec 4, 2019
rladuca
approved these changes
Dec 5, 2019
vatsan-madhavan
added
the
* NO MERGE *
|
Marking as NO-MERGE - we will merge this sometime in Jan '20. |
|
Moved to Mar as per Tactics. Will need to be explicitly approved for Feb, if required. |
vatsan-madhavan
removed
the
* NO MERGE *
SamBent
force-pushed
the
RibbonFocusWar
branch
from
c0fc1fd to
8e6f348
Compare
|
Hello @SamBent! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask Mode Template:
Description
An app that programmatically disables a RibbonMenuButton and replaces its menu items with new ones can cause a focus war leading to infinite recursion and StackOverflow. This can happen if the user presses the toggle button (which opens the menu dropdown) and drags the mouse over the dropdown, and the programmatic disable/replace occurs before the user releases the mouse button.
Customer Impact
Crash.
Regression
No. (Port of servicing fix for .NET 4.7 - 4.8)
Risk
Low
Fixes #2220
StackOverflow due to focus war in RibbonMenuButton