Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Update dependencies from dotnet/arcade #3635

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 1b2e9dc5-44be-480a-8167-08d86afc0648
  • Build: 20201010.1
  • Date Produced: 10/10/2020 1:55 PM
  • Commit: 6813f5aa511a7a4498fa217a54219b5704a01f83
  • Branch: refs/heads/release/5.0
  • Updates to .NET SDKs:
    • Updates sdk.version to 5.0.100-rc.2.20479.15
    • Updates tools.dotnet to 5.0.100-rc.2.20479.15

…010.1

Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.ApiCompat
 From Version 5.0.0-beta.20506.7 -> To Version 5.0.0-beta.20510.1
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner October 12, 2020 18:26
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 12, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent October 12, 2020 18:26
@mmitche
Copy link
Member

mmitche commented Oct 14, 2020

@ryalanms Need any help here?

@ryalanms
Copy link
Member

Looking...

@ryalanms
Copy link
Member

Fixing the first three errors revealed many more. The compiler is giving errors for non-nullable value types checked against null, which is done all over the WPF code.

@mmitche
Copy link
Member

mmitche commented Oct 14, 2020

@ViktorHofer indicated that @jkoritzinsky might have some time to help out with this, since this also affects getting .NET 6 builds flowing.

Replace null comparisons on non-nullable types that now cause compilation errors, due to the .NET SDK update.
@dotnet-maestro dotnet-maestro bot merged commit 6c4051a into release/5.0 Oct 14, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-release/5.0-2e04a9b7-e856-4cd2-83c5-e4456bbd30d0 branch October 14, 2020 23:01
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants