Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #9792

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 17, 2024

Backport of #9791 to release/9.0
/cc @singhashish-wpf @jeffhandley

Customer Impact

We are marking the System.Formats.Nrbf APIs as [Experimental] in .NET 9 to leave the door open for making API changes in the next release. Since WPF consumes these APIs, we need to suppress the diagnostic that will occur.

Testing

Created a local build of System.Formats.Nrbf with the assembly marked as [Experimental], consumed that build into the WPF solution for all references, and found the projects that need to have the suppression in place.

Risk

Low. Suppressing a diagnostic that will be introduced in RC2.

Microsoft Reviewers: Open in CodeFlow

@github-actions github-actions bot requested review from a team as code owners September 17, 2024 10:26
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 17, 2024
@jeffhandley
Copy link
Member

I got clarification from @carlossanlop that we can skip this backport and only backport into release/9.0-rc2. Automation will flow the change from RC2 into the GA branch.

@jeffhandley
Copy link
Member

Chatted with @pchaurasia14. We'll actually merge into release/9.0 in this repo, and then snap the release/9.0-rc2 branch thereafter.

@jeffhandley jeffhandley reopened this Sep 17, 2024
@carlossanlop
Copy link
Member

I got clarification from @carlossanlop that we can skip this backport and only backport into release/9.0-rc2. Automation will flow the change from RC2 into the GA branch.

@jeffhandley I do not know if the dotnet/wpf repo has the same rule of auto flowing release/9.0-rc2 PRs to release/9.0. My suggestion only applied to dotnet/runtime.

@pchaurasia14 do you have that bot enabled in this repo?

@dipeshmsft dipeshmsft merged commit ab82c78 into release/9.0 Sep 17, 2024
8 checks passed
@dipeshmsft dipeshmsft deleted the backport/pr-9791-to-release/9.0 branch September 17, 2024 18:30
@pchaurasia14
Copy link
Member

pchaurasia14 commented Sep 17, 2024

@carlossanlop

do you have that bot enabled in this repo?

Nopes, we don't.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants