Remove XBAP-related dead code from BrowserInteropHelper/SafeSecurityHelper #9855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
...icrosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Interop/BrowserInteropHelper.cs
Show resolved
Hide resolved
This was referenced Oct 1, 2024
h3xds1nz
force-pushed
the
xbap-dead-code
branch
from
77c79de to
0e6db6c
Compare
|
Resolved merge conflicts 08 |
h3xds1nz
force-pushed
the
xbap-dead-code
branch
from
0e6db6c to
aaa30d7
Compare
|
Resolved merge conflicts after #9609 |
harshit7962
approved these changes
Oct 25, 2024
harshit7962
added
Included in test pass
and removed
Queue for test pass
Included in test pass
Status:Committed
labels
|
@h3xds1nz Thank you for the contribution. |
|
@harshit7962 Thanks for including it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes some XBAP-related dead code that hasn't been removed in #1009, mainly from
BrowserInteropHelperand my favouriteSafeSecurityHelper. Also removes the registry paths that are no longer looked up by WPF on .NET Core.I've also hollowed out
DynamicScriptObjectbecause the only way to create an instance was viaHostScriptproperty ofBrowserInteropHelper, which returnsnullon all versions of .NET Core, so you could never initiate one.Customer Impact
Decreased size of assemblies, better code quality of codebase for developers.
Regression
No.
Testing
Local build.
Risk
I believe there is none, XBAP is not supported on .NET Core, this is just leftover code that is uncalled.
Microsoft Reviewers: Open in CodeFlow