Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update EnyimMemcachedCore to 2.5.4 #406

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

jainnipun
Copy link
Contributor

@jainnipun jainnipun commented Oct 13, 2022

Update EnyimMemcachedCore to 2.5.4

Issue:
Using EnyimMemcachedCore v2.5.4 along with EasyCaching.Memcached v1.6.1 in a project fails.

In assembly: EasyCaching.Memcached, Version=1.6.1.0,

the class EasyCachingMemcachedClientConfiguration extends IMemcachedClientConfiguration

IMemcachedClientConfiguration is present in Assembly: EnyimMemcachedCore,

The assembly EnyimMemcachedCore was updated to have a bool variable UseSslStream on April 7 2022 (v 2.5.4).

But the assembly EasyCaching.Memcached still uses v 2.5.3 of EnyimMemcachedCore internally. (csproj link)

So if we try to update the EnyimMemcachedCore to latest version, it will clash.

@catcherwong catcherwong self-requested a review October 13, 2022 14:48
Copy link
Member

@catcherwong catcherwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@catcherwong catcherwong merged commit c32dae1 into dotnetcore:dev Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants