Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the warning xUnit1013 (#457) #458

Merged
merged 1 commit into from
Feb 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -246,7 +246,7 @@ public async Task Refresh_Async_Should_Throw_ArgumentOutOfRangeException_When_Ex
[InlineData("")]
[InlineData(" ")]
[InlineData(null)]
public virtual void RemoveByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(string prefix)
protected virtual void RemoveByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(string prefix)
{
Assert.Throws<ArgumentNullException>(() => _provider.RemoveByPrefix(prefix));
}
@@ -255,7 +255,7 @@ public virtual void RemoveByPrefix_Should_Throw_ArgumentNullException_When_Cache
[InlineData("")]
[InlineData(" ")]
[InlineData(null)]
public async virtual Task RemoveByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(string preifx)
protected async virtual Task RemoveByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(string preifx)
{
await Assert.ThrowsAsync<ArgumentNullException>(async () => await _provider.RemoveByPrefixAsync(preifx));
}
@@ -264,7 +264,7 @@ public async virtual Task RemoveByPrefix_Async_Should_Throw_ArgumentNullExceptio
[InlineData("")]
[InlineData(" ")]
[InlineData(null)]
public virtual void GetAllByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(string prefix)
protected virtual void GetAllByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(string prefix)
{
Assert.Throws<ArgumentNullException>(() => _provider.RemoveByPrefix(prefix));
}
@@ -273,7 +273,7 @@ public virtual void GetAllByPrefix_Should_Throw_ArgumentNullException_When_Cache
[InlineData("")]
[InlineData(" ")]
[InlineData(null)]
public virtual async Task GetAllByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(string preifx)
protected virtual async Task GetAllByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(string preifx)
{
await Assert.ThrowsAsync<ArgumentNullException>(async () => await _provider.RemoveByPrefixAsync(preifx));
}
@@ -874,7 +874,7 @@ protected virtual async Task RemoveByPrefixAsync_Should_Succeed()
#region RemoveByPattern/RemoveByPatternAsync

[Fact]
public virtual void RemoveByPattern_Should_Succeed()
protected virtual void RemoveByPattern_Should_Succeed()
{
SetCacheItem("garden:pots:flowers", "ok");
SetCacheItem("garden:pots:flowers:test", "ok");
@@ -935,7 +935,7 @@ public virtual void RemoveByPattern_Should_Succeed()
}

[Fact]
public virtual async Task RemoveByPatternAsync_Should_Succeed()
protected virtual async Task RemoveByPatternAsync_Should_Succeed()
{
SetCacheItem("garden:pots:flowers", "ok");
SetCacheItem("garden:pots:flowers:test", "ok");
Original file line number Diff line number Diff line change
@@ -76,13 +76,13 @@ protected override void Get_Parallel_Should_Succeed()
{
}

public override Task GetAllByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
protected override Task GetAllByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
string preifx)
{
return Task.CompletedTask;
}

public override void GetAllByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
protected override void GetAllByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
string prefix)
{
}
@@ -132,16 +132,16 @@ protected override void GetExpiration_Should_Succeed()
{
}

public override void RemoveByPattern_Should_Succeed()
protected override void RemoveByPattern_Should_Succeed()
{
}

public override Task RemoveByPatternAsync_Should_Succeed()
protected override Task RemoveByPatternAsync_Should_Succeed()
{
return Task.CompletedTask;
}

public override Task RemoveByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
protected override Task RemoveByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
string preifx)

{
@@ -152,7 +152,7 @@ protected override void RemoveByPrefix_Should_Succeed()
{
}

public override void RemoveByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
protected override void RemoveByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
string prefix)
{
}
Original file line number Diff line number Diff line change
@@ -116,12 +116,12 @@ protected override void GetByPrefix_Should_Succeed()
}

[Fact]
public override void RemoveByPattern_Should_Succeed()
protected override void RemoveByPattern_Should_Succeed()
{
}

[Fact]
public override async Task RemoveByPatternAsync_Should_Succeed()
protected override async Task RemoveByPatternAsync_Should_Succeed()
{
await Task.FromResult(1);
}
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ public void SerializeObject_should_Succeed()
}

[Fact]
public virtual void DeserializeObject_should_Succeed()
protected virtual void DeserializeObject_should_Succeed()
{
object obj = new Model { Prop = "abc" };

Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ public MemoryPackSerializerTest()
}

//This should be overrided becuse it is not supported by memory-pack
public override void DeserializeObject_should_Succeed()
protected override void DeserializeObject_should_Succeed()
{
Person input = new("test", "test1");
var serialized = _serializer.Serialize<Person>(input);