Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images do not reload on OverrideColor change #48

Closed
Fi0x opened this issue May 7, 2021 · 3 comments
Closed

Images do not reload on OverrideColor change #48

Fi0x opened this issue May 7, 2021 · 3 comments

Comments

@Fi0x
Copy link

Fi0x commented May 7, 2021

When I change the OverrideColor property, the image does not get re-loaded with the new value.
I have to use a workaround that uses SetImage.

But I don't think that this is intentional?

@jogibear9988
Copy link
Member

does it work when you call

public void ReRenderSvg()

then i think we need a ChangeNotification in this dependecy property:

typeof(Color?), typeof(SVGImage), new PropertyMetadata(null));

but I've no time to work on this at the moment. Maybe you could and create a pull req?

@Fi0x
Copy link
Author

Fi0x commented May 11, 2021

So I tried to replace SetImage with ReRenderSvg, but unfortunately this does not work.

I'm currently very busy myself, but if I find some time, I'll create a pull-request.

@DrCopyPaste
Copy link

DrCopyPaste commented May 23, 2021

Had the same issue, was able to reproduce this in a simple sample on the example app (double click the rect-image to randomly change color)

this code resolved it for me:
#49

jogibear9988 added a commit that referenced this issue May 23, 2021
changing overridecolor results in rerendering #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants