Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Radial Gradient Defaults #32

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Conversation

williamgarner
Copy link
Contributor

@williamgarner williamgarner commented Sep 11, 2020

Fixed the radial gradient defaults for cx, cy, fx, fy according to https://developer.mozilla.org/en-US/docs/Web/SVG/Element/radialGradient

@paulushub
Copy link
Contributor

Does this resolve any of the W3C test issues/exceptions or the exceptions in the sample files?

@williamgarner
Copy link
Contributor Author

williamgarner commented Sep 11, 2020

I don't think so (mostly because I don't know what W3C test issues/exceptions are) but I am using the package and some of my svgs are not rendering correctly because the radial gradient on the SVG doesn't define fx and fy so the package defaults them to NaN. This means the radial gradient on my image doesn't show up at all.
With this fix SVGs with radial gradients should render properly.

w3.org specifies that the defaults should be what I set them to. https://www.w3.org/TR/SVG11/pservers.html#RadialGradientElementCXAttribute

@paulushub Does that answer your question?

@paulushub
Copy link
Contributor

Yes, I have added a test tool for the W3C test suite. If you fix an issue in it, please make it and check it in. Also, if you resolve any issue and the file can be public, add the file to the Tests / Issues folder.

@paulushub paulushub merged commit 7bd152e into dotnetprojects:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants