Quality/change saml endpoint name #370
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ete-pid fix:fix the manual delete servers.pid file after restart container
…ms#364) refactor ternary operator which creates student_name to ensure nicknames with a value of "" are not rendered
…-unit-load-times Perf/fix project and unit load times
Currently the endpoint that handles SAML authentication is named /auth/jwt. This endpoint still exists, and there is a new endpoint called /auth/saml2 which will eventually replace the former.
Moved copied /auth/jwt and /auth/saml2 logic into a seperate file with function
jakerenzella
requested changes
Mar 27, 2022
There was a problem hiding this comment.
Looks good @sneaky-patriki, congrats on first PR - a quick small change
|
Hi @sneaky-patriki, Thanks for the PR. Can you make a small change? Move the AuthSaml to a "helper" - put it in app/helpers folder. Rename it and the file to AuthSamlHelper. Then you can include this in the authentication API like the authentication helper. |
|
Just thinking @macite should we move into a helpers/auth dir? I think all the auth handlers could be brought out into their own file - AAF/SAML/database etc? |
|
Yes that would be a good idea. Then that would clear up the API a lot... |
|
@sneaky-patriki sorry as per my comment above can we get this into |
Change authsamlhelper class to module, mark as helper for and prefix correctly Remove import authsamlhelper since helpers are imported by default
sneaky-patriki
force-pushed
the
quality/change-saml-endpoint-name
branch
from
1460564 to
8aa1203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new endpoint /auth/saml2 for SAML authentication
This uses the same logic as /auth/jwt (which should be SAML and will be decommissioned)
Pulled out logic into a seperate function
Fixes # (issue)
Type of change
Refactoring
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Ran unit test suite locally
Checklist:
If you have any questions, please contact @macite or @jakerenzella.