FIX: Ensure dynamic page routing enabled

doubtfire-lms · Jul 9, 2019 · a3f58b2 · a3f58b2
1 parent 991b8e6
commit a3f58b2
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/src/app/projects/states/dashboard/dashboard.coffee b/src/app/projects/states/dashboard/dashboard.coffee
@@ -11,6 +11,8 @@ angular.module('doubtfire.projects.states.dashboard', [
     url: '/dashboard/:taskAbbr?tutor'
     controller: 'ProjectsDashboardStateCtrl'
     templateUrl: 'projects/states/dashboard/dashboard.tpl.html'
+    params:
+      taskAbbr: dynamic: true
     data:
       task: "Dashboard"
       pageTitle: "_Home_"

diff --git a/src/app/projects/states/feedback/feedback.coffee b/src/app/projects/states/feedback/feedback.coffee
@@ -4,9 +4,10 @@ angular.module('doubtfire.projects.states.feedback', [])
 # Skips directly to feedback view (is a child of projects#show)
 # of a specific task id
 #
-.config(($stateProvider) ->
-  projectsFeedbackStateData =
-    url: ":viewing/:showTaskId"
-    parent: 'projects#show'
-  $stateProvider.state "projects#feedback", projectsFeedbackStateData
-)
+# This may be completely gone...
+# .config(($stateProvider) ->
+#   projectsFeedbackStateData =
+#     url: ":viewing/:showTaskId"
+#     parent: 'projects#show'
+#   $stateProvider.state "projects#feedback", projectsFeedbackStateData
+# )
diff --git a/src/app/units/states/tasks/definition/definition.coffee b/src/app/units/states/tasks/definition/definition.coffee
@@ -12,6 +12,8 @@ angular.module('doubtfire.units.states.tasks.definition', [
     # We can recycle the task inbox, switching the data source scope variable
     templateUrl: "units/states/tasks/inbox/inbox.tpl.html"
     controller: "TaskDefinitionStateCtrl"
+    params:
+      taskKey: dynamic: true
     data:
       task: "Mark by Task Definition"
       pageTitle: "_Home_"

diff --git a/src/app/units/states/tasks/feedback/feedback.coffee b/src/app/units/states/tasks/feedback/feedback.coffee
@@ -12,6 +12,8 @@ angular.module('doubtfire.units.states.tasks.feedback', [
     # We can recycle the task inbox, switching the data source scope variable
     templateUrl: "units/states/tasks/inbox/inbox.tpl.html"
     controller: "TaskFeedbackStateCtrl"
+    params:
+      taskKey: dynamic: true
     data:
       task: "Give Student Feedback"
       pageTitle: "_Home_"

diff --git a/src/app/units/states/tasks/inbox/inbox.coffee b/src/app/units/states/tasks/inbox/inbox.coffee
@@ -11,6 +11,8 @@ angular.module('doubtfire.units.states.tasks.inbox', [
     url: '/inbox/{taskKey:any}'
     templateUrl: "units/states/tasks/inbox/inbox.tpl.html"
     controller: "TaskInboxStateCtrl"
+    params:
+      taskKey: dynamic: true
     data:
       task: "Task Inbox"
       pageTitle: "_Home_"

diff --git a/src/app/units/states/tasks/viewer/viewer.coffee b/src/app/units/states/tasks/viewer/viewer.coffee
@@ -8,8 +8,7 @@ angular.module('doubtfire.units.states.tasks.viewer', [
 .config(($stateProvider) ->
   $stateProvider.state 'units/tasks/viewer', {
     parent: 'units/tasks'
-    url: '/viewer/{taskKey:any}'
-    # We can recycle the task inbox, switching the data source scope variable
+    url: '/viewer'
     templateUrl: "units/states/tasks/viewer/viewer.tpl.html"
     controller: "TaskViewerStateCtrl"
     data: