fix: ensure blobs are freed on destroy

doubtfire-lms · May 11, 2023 · ee017eb · ee017eb
1 parent a1e51b6
commit ee017eb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/app/common/pdf-viewer/pdf-viewer.component.ts b/src/app/common/pdf-viewer/pdf-viewer.component.ts
@@ -27,6 +27,7 @@ export class fPdfViewerComponent implements OnDestroy, OnChanges {
   ngOnDestroy(): void {
     if (this.pdfBlobUrl) {
       this.fileDownloader.releaseBlob(this.pdfBlobUrl);
+      this.pdfBlobUrl = null;
     }
   }
 

diff --git a/src/app/tasks/task-comments-viewer/pdf-image-comment/pdf-image-comment.component.ts b/src/app/tasks/task-comments-viewer/pdf-image-comment/pdf-image-comment.component.ts
@@ -1,4 +1,4 @@
-import { Component, OnInit, Input, Inject } from '@angular/core';
+import { Component, OnInit, Input, Inject, OnDestroy } from '@angular/core';
 import { alertService, commentsModal } from 'src/app/ajs-upgraded-providers';
 import { Project, TaskComment, Task } from 'src/app/api/models/doubtfire-model';
 import { FileDownloaderService } from 'src/app/common/file-downloader/file-downloader';
@@ -8,7 +8,7 @@ import { FileDownloaderService } from 'src/app/common/file-downloader/file-downl
   templateUrl: './pdf-image-comment.component.html',
   styleUrls: [],
 })
-export class PdfImageCommentComponent implements OnInit {
+export class PdfImageCommentComponent implements OnInit, OnDestroy {
   @Input() comment: TaskComment;
   @Input() project: Project;
   @Input() task: Task;
@@ -25,6 +25,13 @@ export class PdfImageCommentComponent implements OnInit {
     if (this.comment.commentType === 'image') this.downloadCommentResource();
   }
 
+  ngOnDestroy(): void {
+    if (this.resourceUrl) {
+      this.fileDownloaderService.releaseBlob(this.resourceUrl);
+      this.resourceUrl = null;
+    }
+  }
+
   private downloadCommentResource(fn?: (url: string) => void) {
     const url = this.comment.attachmentUrl;