Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MS SQL Server #197

Closed
vasayxtx opened this issue Feb 17, 2020 · 4 comments
Closed

Support MS SQL Server #197

vasayxtx opened this issue Feb 17, 2020 · 4 comments
Assignees
@doug-martin

Comments

@vasayxtx
Copy link

vasayxtx commented Feb 17, 2020 •
edited
Loading

Hi,
Thanks for the great query builder! What do you think about supporting Microsoft SQL Server?
@doug-martin
Copy link
Owner

Yeah, I would have no problems with that if you want to create a PR with the adapter and tests that would be great!

doug-martin added a commit that referenced this issue Mar 16, 2020
@doug-martin
Merge pull request #205 from vlanse/feature/sqlserver-support
6cb3453 
add support for sqlserver dialect, #197
@vlanse
Copy link
Contributor

vlanse commented Mar 16, 2020

@doug-martin looks like this could be closed now.
btw, do you plan to merge sqlserver support in master branch also?

@doug-martin
Copy link
Owner

@vlanse yeah I will once, I do all the house keeping stuff with the release

doug-martin added a commit that referenced this issue Mar 16, 2020
@doug-martin
v9.7.0
198a7ac 
* [ADDED] Support for sqlserver dialect #197,#205 - @vlanse
@doug-martin doug-martin mentioned this issue Mar 16, 2020
Merged
@doug-martin
Copy link
Owner

Released in v9.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doug-martin doug-martin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doug-martin @vasayxtx @vlanse