Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sqlserver dialect, #197 #205

Merged
merged 16 commits into from
Mar 16, 2020
Merged

add support for sqlserver dialect, #197 #205

merged 16 commits into from
Mar 16, 2020

Conversation

vlanse
Copy link
Contributor

@vlanse vlanse commented Mar 12, 2020

No description provided.

dialect/sqlserver/sqlserver.go Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
sqlgen/common_sql_generator.go Outdated Show resolved Hide resolved
dialect/sqlserver/sqlserver_test.go Outdated Show resolved Hide resolved
@doug-martin
Copy link
Owner

Sorry, about the merge conflict. I changed the workflow to use the codecov github action now that it supports tokenless uploads. Now coverage should be checked on PRs from forks.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #205 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   96.26%   96.34%   +0.08%     
==========================================
  Files          57       58       +1     
  Lines        4017     4109      +92     
==========================================
+ Hits         3867     3959      +92     
  Misses        135      135              
  Partials       15       15
Impacted Files Coverage Δ
sqlgen/select_sql_generator.go 100% <100%> (ø) ⬆️
dialect/sqlite3/sqlite3.go 100% <100%> (ø) ⬆️
sqlgen/expression_sql_generator.go 100% <100%> (ø) ⬆️
dialect/sqlserver/sqlserver.go 100% <100%> (ø)
sqlgen/sql_dialect_options.go 100% <100%> (ø) ⬆️
dialect/mysql/mysql.go 100% <100%> (ø) ⬆️
dialect/postgres/postgres.go 100% <100%> (ø) ⬆️
sqlgen/common_sql_generator.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a583f...17531e7. Read the comment docs.

Copy link
Owner

@doug-martin doug-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

sqlgen/sql_dialect_options.go Outdated Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
docs/dialect.md Outdated Show resolved Hide resolved
@vlanse vlanse requested a review from doug-martin March 13, 2020 19:30
@vlanse
Copy link
Contributor Author

vlanse commented Mar 16, 2020

@doug-martin could you please proceed with review?

@doug-martin doug-martin changed the base branch from master to v9.7.0 March 16, 2020 20:02
@doug-martin doug-martin merged commit 6cb3453 into doug-martin:v9.7.0 Mar 16, 2020
@vlanse vlanse deleted the feature/sqlserver-support branch March 16, 2020 20:08
doug-martin added a commit that referenced this pull request Mar 16, 2020
* [ADDED] Support for sqlserver dialect #197,#205 - @vlanse
@doug-martin doug-martin mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants