Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in query factory initialisation #133

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Fix data race in query factory initialisation #133

merged 1 commit into from
Aug 22, 2019

Conversation

o1egl
Copy link
Contributor

@o1egl o1egl commented Aug 15, 2019

Fixes #136

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #133 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #133      +/-   ##
========================================
+ Coverage   89.94%    90%   +0.06%     
========================================
  Files          47     47              
  Lines        3561   3563       +2     
========================================
+ Hits         3203   3207       +4     
+ Misses        324    322       -2     
  Partials       34     34
Impacted Files Coverage Δ
database.go 89.82% <100%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cfb20...cc41938. Read the comment docs.

database_test.go Outdated Show resolved Hide resolved
database.go Outdated Show resolved Hide resolved
@doug-martin
Copy link
Owner

For tracking purposes and if someone else is searching for answers related to this problem can you add a short description about the addition, and what your use case was?

@o1egl
Copy link
Contributor Author

o1egl commented Aug 18, 2019

For tracking purposes and if someone else is searching for answers related to this problem can you add a short description about the addition, and what your use case was?

Done

@doug-martin doug-martin merged commit 9bf6e8d into doug-martin:master Aug 22, 2019
@doug-martin doug-martin mentioned this pull request Aug 22, 2019
doug-martin added a commit that referenced this pull request Aug 22, 2019
* [FIXED] Data race during query factory initialization #133 and #136 - @o1egl
@o1egl o1egl deleted the fix_race branch August 22, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race during query factory initialisation
2 participants