Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #140 #142

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Fix for #140 #142

merged 1 commit into from
Aug 22, 2019

Conversation

doug-martin
Copy link
Owner

  • changed exp.NewColumnList to ignore nil values

@doug-martin doug-martin mentioned this pull request Aug 22, 2019
Closed
golangcibot
golangcibot reviewed Aug 22, 2019
View reviewed changes
exp/col.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #142 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   91.69%   91.69%   +<.01%     
==========================================
  Files          53       53              
  Lines        3588     3589       +1     
==========================================
+ Hits         3290     3291       +1     
  Misses        279      279              
  Partials       19       19
Impacted Files Coverage Δ
exp/col.go 75.55% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6b1d6...e718b63. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 22, 2019 •
edited
Loading

Codecov Report

Merging #142 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   91.69%   91.69%   +<.01%     
==========================================
  Files          53       53              
  Lines        3588     3589       +1     
==========================================
+ Hits         3290     3291       +1     
  Misses        279      279              
  Partials       19       19
Impacted Files Coverage Δ
exp/col.go 75.55% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6b1d6...e718b63. Read the comment docs.

@doug-martin doug-martin merged commit 8d914fd into master Aug 22, 2019
@doug-martin doug-martin deleted the issue140 branch October 16, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doug-martin @golangcibot