Support for defining WITH clauses for Common Table Expressions (CTE) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 7, 2017 18:41
- conditional support in the default adapter - tests at dataset level and also examples
Note that the beta MySQL 8.0 supports CTE; as does MariaDB 10.x
Add and improve examples, docs
Oscil8
force-pushed
the
add-with-cte
branch
3 times, most recently
from
8a84a4e to
cfc8e7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
- Coverage 83.66% 83.06% -0.6%
=========================================
Files 17 17
Lines 2020 2085 +65
=========================================
+ Hits 1690 1732 +42
- Misses 233 246 +13
- Partials 97 107 +10
Continue to review full report at Codecov.
|
|
Found an issue with the Travis build; see my last commit for the fix for the "vanity" package name (from the Travis docs). Wondering what you recommend on the coverage test results -- are there any particular tests you'd recommend that I'm missing? |
|
@Oscil8 Ill take a look at this either later today or tomorrow thanks for the pr! |
|
Any comments @doug-martin ? |
doug-martin
reviewed
Jun 6, 2017
default_adapter.go
Outdated
| @@ -217,6 +225,8 @@ func NewDefaultAdapter(ds *Dataset) Adapter { | |||
| SelectClause: default_select_clause, | |||
| DeleteClause: default_delete_clause, | |||
| TruncateClause: default_truncate_clause, | |||
| WithFragment: default_with_fragment, | |||
| RecursiveFragment: default_recursive_fragment, | |||
|
Addressed the formatting issue |
doug-martin
added a commit
that referenced
this pull request
Jun 12, 2017
Merged
doug-martin
added a commit
that referenced
this pull request
Jun 12, 2017
doug-martin
added a commit
that referenced
this pull request
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great library; I've found it very useful and filled my needs for query generation. Just found one missing element that did exist in some of the other major query generators which is support for Common Table Expressions (CTEs), i.e. WITH clauses. This includes both WITH and WITH RECURSIVE versions and applies them to SELECT, UPDATE, DELETE and INSERT queries (although I am just using them in the SELECT context).
These are a useful way to build efficient queries by re-using commonly used subparts. They are supported in PostgreSQL (https://www.postgresql.org/docs/current/static/queries-with.html) and SQLite (https://sqlite.org/lang_with.html); and I noticed in the upcoming MySQL 8.0 currently in Beta (https://dev.mysql.com/doc/refman/8.0/en/with.html). I'm using PostgreSQL.
Would appreciate your feedback on the way I have added the WITH clauses to goqu; as well as appropriate level of test and documentation. I aimed for a similar level as for the Union and related clauses.