Handle nil *time.Time Literal (PR #52) + test #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 80.72% 80.74% +0.01%
==========================================
Files 17 17
Lines 2169 2171 +2
==========================================
+ Hits 1751 1753 +2
Misses 310 310
Partials 108 108
Continue to review full report at Codecov.
|
|
Any issues on this PR that prevent it to be merged? |
Merged
|
I merged this into v6.1.0-rc with #82 I plan on getting a few other features in then publishing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically code from PR #52 with added test case. Credits go to @RoarkeRandall