vcsim: RetrievePropertiesEx & ContinueRetrievePropertiesEx #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support to vC Sim for RetrievePropertiesEx and ContinueRetrievePropertiesEx and their paged results semantics.
akutz
force-pushed
the
feature/RetrievePropertiesEx
branch
from
f295e8b to
dd4d839
Compare
|
Thank you @akutz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support to vC Sim for
RetrievePropertiesExandContinueRetrievePropertiesExand their paged results semantics.There is now coverage for the wrapped
RetrievePropertiesExcall inside of the collector'sRetrievePropertiesmethod:The use of paging may be validated by setting a conditional break point such that it breaks only when there are two attempts to continue paging:
The reason it hits on two attempts is because the first call to
RetrievePropertiesExreturns a single object, and since there are three objects to return, it takes two more calls toContinueRetrievePropertiesExto obtain that data.