Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Auto format code using prettier before commit #224

Merged
merged 11 commits into from
Apr 13, 2019
Merged

style: Auto format code using prettier before commit #224

merged 11 commits into from
Apr 13, 2019

Conversation

mrchief
Copy link
Collaborator

@mrchief mrchief commented Mar 27, 2019

What does it do?

Adds prettierrc and pre commit hooks to format code automatically. Cleans up eslintrc and switched to react-app lint rules

@coveralls
Copy link

coveralls commented Mar 27, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1029

  • 6 of 6 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.862%
Totals Coverage Status
Change from base Build 1025: 0.0%
Covered Lines: 325
Relevant Lines: 335
💛 - Coveralls

ellinge
ellinge suggested changes Mar 27, 2019
View reviewed changes
package.json Show resolved Hide resolved
@mrchief
Copy link
Collaborator Author

mrchief commented Mar 27, 2019

@ellinge I'm going to hold on to this PR till we merge the older ones first. That way, we have to solve conflicts in one branch as opposed to solving in 3 otherwise.

mrchief and others added 3 commits March 31, 2019 13:40
@mrchief
Merge branch 'develop' into prettier
d93c221 
# Conflicts:
#	package.json
#	src/index.js
#	src/index.test.js
#	src/tree-manager/flatten-tree.js
#	src/tree-manager/index.js
#	src/tree-node/node-label.js
#	webpack.config.js
@mrchief
chore: Fix linting/formatting after merge
c47bf7f
@ellinge
Merge branch 'develop' into prettier
51ec6fa
@mrchief
Copy link
Collaborator Author

mrchief commented Apr 4, 2019

Maybe we should merge this now? I don't think I can ever catch up to you :)

ellinge
ellinge previously approved these changes Apr 4, 2019
View reviewed changes
@ellinge
Copy link
Collaborator

ellinge commented Apr 4, 2019 •
edited
Loading

Sure! Hoped it was the radioSelect @ first from the mail notification... 🥈

Seems to be some build errors though.

@mrchief
Copy link
Collaborator Author

mrchief commented Apr 5, 2019

Sure! Hoped it was the radioSelect @ first from the mail notification... 🥈

Alright, alright! We'll do this after radio select then 😃

Seems to be some build errors though.

We need to pretty things after every merge 🎀

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2019

Code Climate has analyzed commit f98a52b and detected 0 issues on this pull request.

View more on Code Climate.

@mrchief mrchief merged commit d7604e7 into develop Apr 13, 2019
@mrchief mrchief deleted the prettier branch April 13, 2019 23:49
mrchief added a commit that referenced this pull request Apr 18, 2019
@mrchief
style: Auto format code using prettier before commit (#224)
7ae71bb 
## What does it do?

Adds prettierrc and pre commit hooks to format code automatically. Cleans up eslintrc and switched to react-app lint rules
@mrchief
Copy link
Collaborator Author

mrchief commented Jun 10, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellinge ellinge ellinge left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrchief @coveralls @ellinge