fix(hooks): do not accept undefined as initial values (#1398)

src/hooks/__tests__/utils.test.js

@@ -1,4 +1,9 @@
-import {getItemIndex, defaultProps} from '../utils'
+import {
+  getItemIndex,
+  defaultProps,
+  getInitialValue,
+  getDefaultValue,
+} from '../utils'
 
 describe('utils', () => {
   describe('itemToString', () => {
@@ -25,4 +30,37 @@ describe('utils', () => {
       expect(index).toBe(1)
     })
   })
+
+  test('getInitialValue will not return undefined as initial value', () => {
+    const defaults = {bogusValue: 'hello'}
+    const value = getInitialValue(
+      {initialBogusValue: undefined},
+      'bogusValue',
+      defaults,
+    )
+
+    expect(value).toEqual(defaults.bogusValue)
+  })
+
+  test('getInitialValue will not return undefined as value', () => {
+    const defaults = {bogusValue: 'hello'}
+    const value = getInitialValue(
+      {bogusValue: undefined},
+      'bogusValue',
+      defaults,
+    )
+
+    expect(value).toEqual(defaults.bogusValue)
+  })
+
+  test('getDefaultValue will not return undefined as value', () => {
+    const defaults = {bogusValue: 'hello'}
+    const value = getDefaultValue(
+      {defaultBogusValue: undefined},
+      'bogusValue',
+      defaults,
+    )
+
+    expect(value).toEqual(defaults.bogusValue)
+  })
 })

src/hooks/utils.js

@@ -225,10 +225,10 @@ function getDefaultValue(
   propKey,
   defaultStateValues = dropdownDefaultStateValues,
 ) {
-  const defaultPropKey = `default${capitalizeString(propKey)}`
+  const defaultValue = props[`default${capitalizeString(propKey)}`]
 
-  if (defaultPropKey in props) {
-    return props[defaultPropKey]
+  if (defaultValue !== undefined) {
+    return defaultValue
   }
 
   return defaultStateValues[propKey]
@@ -239,15 +239,18 @@ function getInitialValue(
   propKey,
   defaultStateValues = dropdownDefaultStateValues,
 ) {
-  if (propKey in props) {
-    return props[propKey]
+  const value = props[propKey]
+
+  if (value !== undefined) {
+    return value
   }
 
-  const initialPropKey = `initial${capitalizeString(propKey)}`
+  const initialValue = props[`initial${capitalizeString(propKey)}`]
 
-  if (initialPropKey in props) {
-    return props[initialPropKey]
+  if (initialValue !== undefined) {
+    return initialValue
   }
+
   return getDefaultValue(props, propKey, defaultStateValues)
 }