Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve code in hooks #1213

Merged
merged 4 commits into from
Jan 8, 2021
Merged

perf: improve code in hooks #1213

merged 4 commits into from
Jan 8, 2021

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Jan 2, 2021

What:
Improves the code in the hooks.

Why:
Reduced bundle size and better maintainability.

How:

  • Some common state change types.
  • A partial common reducer.
  • Only add function implementation if not on production, for some dev utils. (controlled/uncontrolled, getter props called, prop change types).
  • useElementIds.
  • getItemIndexByCharacterKey

Also updated some dependencies.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@silviuaavram silviuaavram merged commit a3103d7 into master Jan 8, 2021
@silviuaavram silviuaavram deleted the perf/improve-code branch January 8, 2021 15:17
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🎉 This PR is included in version 6.0.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

silviuaavram added a commit that referenced this pull request Jan 11, 2021
silviuaavram added a commit that referenced this pull request Jan 11, 2021
@silviuaavram silviuaavram restored the perf/improve-code branch January 11, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant