Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-644
What I did
Note:
ripple-framework/packages/nuxt-ripple/components/TideBreadcrumbs.vue
Line 35 in dec415c
-- This adds a breadcrumb item with the page title, in the case of the reference site this is ‘Demo landing page’
-- The home link is currently added automatically on the front end so we either need
--- the backend to stop setting the home page as the parent by default
--- get the backend to automatically use the text ‘Home’ if that page is the home page
--- or update all pages set as the ‘home page’ with a custom Breadcrumb Name i.e. ‘Home’ on said page
-- Otherwise we’d have to do another seperate request to check if the first breadcrumb items is the home page
Checklist
For all PR's
For new UI components only
emitRplEvent