Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-644] CMS breadcrumbs #1439

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[SD-644] CMS breadcrumbs #1439

wants to merge 1 commit into from

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 3, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-644

What I did

  • Add support for CMS breadcrumbs

Note:

  • This update will use the new CMS supplied breadcrumbs and fallback to the existing nav calculated breadcrumbs:
    const breadcrumbs = computed(() => {
  • Saving a page without manually choosing a breadcrumb parent will result in the home page being added as it’s parent
    -- This adds a breadcrumb item with the page title, in the case of the reference site this is ‘Demo landing page’
    -- The home link is currently added automatically on the front end so we either need
    --- the backend to stop setting the home page as the parent by default
    --- get the backend to automatically use the text ‘Home’ if that page is the home page
    --- or update all pages set as the ‘home page’ with a custom Breadcrumb Name i.e. ‘Home’ on said page
    -- Otherwise we’d have to do another seperate request to check if the first breadcrumb items is the home page

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.25.0 milestone Feb 3, 2025
@lambry lambry self-assigned this Feb 3, 2025
@lambry lambry marked this pull request as ready for review February 3, 2025 23:02
@lambry lambry marked this pull request as draft February 3, 2025 23:09
@dylankelly dylankelly removed this from the 2.25.0 milestone Feb 4, 2025
Base automatically changed from release/2.25.0 to develop February 4, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants