Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-486] allow requiring a suggestion in RplSearchBar #1443

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 9, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-486

What I did

  • Implements the new map search bar changes, basically this just adds a prop to RplSearchBar that allows for a suggestion to be required for submission.
  • Adds props to set iconPosition and showSubmitButton

This fixes a couple behavioral issues, for example currently pressing enter or the search button does nothing, unless you have already preformed a search then it will behave the same as the clear button, i.e. hitting enter or clicking search button deletes what you've typed in and performs a new search.

rpl-search-bar

map-search

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.26.0 milestone Feb 9, 2025
@lambry lambry self-assigned this Feb 9, 2025
@lambry lambry changed the title [SD-486] allow requiring a suggesting in RplSearchBar [SD-486] allow requiring a suggestion in RplSearchBar Feb 10, 2025
Copy link

cypress bot commented Feb 12, 2025

ripple-framework    Run #2560

Run Properties:  status check passed Passed #2560  •  git commit 83add0907d: feat(@dpc-sdp/ripple-ui-core): add iconPosition and showSubmitButton props to Rp...
Project ripple-framework
Branch Review feature/map-search-bar
Run status status check passed Passed #2560
Run duration 11m 41s
Commit git commit 83add0907d: feat(@dpc-sdp/ripple-ui-core): add iconPosition and showSubmitButton props to Rp...
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 237
View all changes introduced in this branch ↗︎

Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the extra props - LGTM

@lambry lambry merged commit 1f9e065 into release/2.26.0 Feb 13, 2025
13 of 14 checks passed
@lambry lambry deleted the feature/map-search-bar branch February 13, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants