[SD-695] Use DL in stats grid markup #1446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-695
What I did
Ideally, the stats blocks would all form onedl
but the rules say that adl
can only containdt
anddd
els, so there is no way of wrapping them for alignment in flex. I think this (using adl
for each pair) is still correct, but a bit verbose - no difference visually or in size of markup.dl
withdt
anddd
(wrapped in a single div), use border instead of margin/gapHow to test
Checklist
For all PR's
For new UI components only
emitRplEvent