Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-711] Fix two separate font issues #1447

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-711

What I did

  • Added Burmese to highlight header CSS fix (used in Arabic)
  • Added Dinka font settings to map to Noto Sans (has better symbol support than VIC)

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.26.0 milestone Feb 12, 2025
@waitingallday waitingallday self-assigned this Feb 12, 2025
Copy link

cypress bot commented Feb 12, 2025

ripple-framework    Run #2561

Run Properties:  status check passed Passed #2561  •  git commit abd3aa8109: feat: :sparkles: add dinka font settings
Project ripple-framework
Branch Review feat/sd-711-more-rtl-headers
Run status status check passed Passed #2561
Run duration 11m 36s
Commit git commit abd3aa8109: feat: :sparkles: add dinka font settings
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 235
View all changes introduced in this branch ↗︎

@waitingallday waitingallday merged commit 74fcefa into release/2.26.0 Feb 13, 2025
6 checks passed
@waitingallday waitingallday deleted the feat/sd-711-more-rtl-headers branch February 13, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants