Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass descendant combinator typeerror #78

Closed
wants to merge 1 commit into from

Conversation

computnik
Copy link

@computnik computnik commented Mar 17, 2023

Motivation and context:

The nwsapi parsing gives TypeError in cases like below:

  &:disabled {
      svg path {
          fill: var(--color-brand-primary)
      } 
  }

image
TypeError: Cannot read properties of null (reading 'parentElement')

This change checks for null value when parsing the Descendant combinator, and can potentially bypass TypeErrors like in #75

@computnik computnik marked this pull request as draft March 17, 2023 05:34
@computnik computnik marked this pull request as ready for review March 28, 2023 17:13
@computnik computnik changed the title fix: descendant combinator typeerror fix fix: bypass descendant combinator typeerror Mar 28, 2023
Copy link

@ahayes91 ahayes91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dperini
Copy link
Owner

dperini commented Apr 6, 2023

@computnik
I changed strategy for resolving combinators for when there are extreme combinators nesting.
At each nesting level a new variable is created/retained so it will be impossible to overwrite them.
See this commit 12f9f59

@dperini dperini closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants