Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask_appbuilder/static/appbuilder/css/font-awesome.min.css file is missing in the source distribution #2059

Closed
bkyryliuk opened this issue Jun 13, 2023 · 4 comments

Comments

@bkyryliuk
Copy link
Contributor

flask_appbuilder/static/appbuilder/css/font-awesome.min.css file is missing in the source distribution but is present in the wheel.
To manually check it, it is possible to download files form https://pypi.org/project/Flask-AppBuilder/#files unpack or wheel unpack and check the context

This leads to a missing font in superset that uses flask app builder >= 4.3.0
image

Environment

Flask-Appbuilder version: >= 4.3.0

Steps to reproduce

pip install Flask-AppBuilder==4.3.2 --no-binary :all: and check that is missing in the distribution

alternatively run superset with the Flask-AppBuilder built from source and check editing the columns in the datasets, expand button will be missing due to the missing css file.

@dpgaspar
Copy link
Owner

I believe the name changed, it's called css/fontawesome/fontawesome.min.css now

@bkyryliuk
Copy link
Contributor Author

yep, saw that however superset somehow is still referencing flask_appbuilder/static/appbuilder/css/font-awesome.min.css and that file is present in the wheel distribution.
Unfortunately I don't know much how fonts / css files are discovered to provide more info here

@dpgaspar
Copy link
Owner

checking if Superset should be calling super() on that block

@dpgaspar
Copy link
Owner

fixed on Superset apache/superset#24390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants