Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FAB CSS on Superset #24390

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

dpgaspar
Copy link
Member

SUMMARY

Fixes reported issue on FAB, select2, font-awesome versions were bumped and static css locations changed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested review from craig-rueda and bkyryliuk and removed request for craig-rueda June 13, 2023 15:20
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #24390 (f109e23) into master (ca478bd) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f109e23 differs from pull request most recent head 6498c80. Consider uploading reports for the commit 6498c80 to get more accurate results

@@            Coverage Diff             @@
##           master   #24390      +/-   ##
==========================================
- Coverage   68.99%   68.98%   -0.02%     
==========================================
  Files        1903     1903              
  Lines       74196    74123      -73     
  Branches     8110     8110              
==========================================
- Hits        51194    51135      -59     
+ Misses      20890    20876      -14     
  Partials     2112     2112              
Flag Coverage Δ
hive 54.00% <ø> (-0.05%) ⬇️
mysql 79.30% <ø> (-0.01%) ⬇️
postgres 79.38% <ø> (-0.01%) ⬇️
presto 53.93% <ø> (-0.05%) ⬇️
python 83.35% <ø> (+<0.01%) ⬆️
sqlite 77.88% <ø> (-0.01%) ⬇️
unit 54.50% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 93.83% <ø> (ø)
superset/views/core.py 74.16% <ø> (-0.60%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it fixes the issue. Thanks !

@dpgaspar dpgaspar merged commit 1328c56 into apache:master Jun 13, 2023
@dpgaspar dpgaspar deleted the fix/fab-css-on-superset branch June 13, 2023 15:51
eschutho pushed a commit that referenced this pull request Jul 20, 2023
(cherry picked from commit 1328c56)
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants