Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom menu option #1884

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix: custom menu option #1884

merged 1 commit into from
Jul 5, 2022

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jul 5, 2022

Description

Fixes custom menu, based on: #1875

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@dpgaspar dpgaspar mentioned this pull request Jul 5, 2022
6 tasks
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1884 (1cbafdc) into master (cc8e359) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
+ Coverage   77.67%   77.74%   +0.07%     
==========================================
  Files          70       70              
  Lines        8560     8560              
==========================================
+ Hits         6649     6655       +6     
+ Misses       1911     1905       -6     
Flag Coverage Δ
python 77.74% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/base.py 81.00% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8e359...1cbafdc. Read the comment docs.

@dpgaspar dpgaspar merged commit 40e1e14 into master Jul 5, 2022
@dpgaspar dpgaspar deleted the fix/custom-menu branch July 5, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant