-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: relax marshmallow-sqlalchemy version constraint to fix compatibility with marshmallow>=3.24 #2298
base: master
Are you sure you want to change the base?
fix: relax marshmallow-sqlalchemy version constraint to fix compatibility with marshmallow>=3.24 #2298
Conversation
…th marshmallow>=3.24
given that marshmallow 4.0 will be released soon, i also think the version constraint for marshmallow should also be relaxed to but this can happen as a follow-up |
Nice one - would be great to get it in :) |
setup.py
Outdated
@@ -58,7 +58,7 @@ def desc(): | |||
"Flask-JWT-Extended>=4.0.0, <5.0.0", | |||
"jsonschema>=3, <5", | |||
"marshmallow>=3.18.0, <4", | |||
"marshmallow-sqlalchemy>=0.22.0, <0.29.0", | |||
"marshmallow-sqlalchemy>=0.22.0, <2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should remove the upper bound altogether
"marshmallow-sqlalchemy>=0.22.0, <2.0.0", | |
"marshmallow-sqlalchemy>=0.22.0", |
to avoid issues like the one that Airflow ran into. since FAB is a library, its shouldn't impose such strict upper constraints on its dependencies and allow users to pin their own dependencies
i've relaxed the versions for both marshmallow and marshmallow-sqlachemy even further because there are major releases planned within the next month for both but neither should affect FAB |
Description
Relax the upper marshmallow-sqlalchemy version constraint. This is necessary for compatibility with newer versions of marshmallow (>=3.24.0).
This would resolve this issue in Airflow: apache/airflow#45442 (comment)
This also upgrades a few dependencies needed for a working development environment (used
pip-compile --upgrade-package ...
).ADDITIONAL INFORMATION